Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Null Safety Support #13

Closed
JohnGalt1717 opened this issue Jan 6, 2021 · 7 comments · Fixed by #14
Closed

Null Safety Support #13

JohnGalt1717 opened this issue Jan 6, 2021 · 7 comments · Fixed by #14

Comments

@JohnGalt1717
Copy link

Hi there,

Any chance of getting this package updated for null safety support and published as beta like most other packages are doing?

@bayuly94
Copy link

bayuly94 commented Mar 4, 2021

use this

responsive_grid:
git:
url: git://github.com/mohamed-selim-a/ResponsiveGrid_Flutter.git
ref: 22ee88e

@muhammad369
Copy link
Owner

Excuse me for the late response

I can't figure out whether the migration of the pkg requires the referencing app to also migrate to null safety or not

@mzdm
Copy link
Contributor

mzdm commented Apr 4, 2021

Excuse me for the late response

I can't figure out whether the migration of the pkg requires the referencing app to also migrate to null safety or not

Official guide https://dart.dev/null-safety/migration-guide

Not sure what you mean with referencing but I have already made a PR #14 with all the changes.

@muhammad369
Copy link
Owner

I mean the app that is using the pkg
should it be migrated also to null safety to be able to use this version

@mzdm
Copy link
Contributor

mzdm commented Apr 4, 2021

Yes all packages need to be migrated to migrate the package itself to null safety too. But I'm checking pubspec.yaml and don't see any package dependency?

@mzdm
Copy link
Contributor

mzdm commented Apr 4, 2021

@mohamed-selim-a I've resolved conflicts from the 1.3.0 version. If there's anything needed to be addressed please let me know

@muhammad369
Copy link
Owner

Thanks for your PR
I'll merge it and close the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants