Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Project Structure #44

Closed
mayur-ravindram opened this issue Jan 2, 2022 · 3 comments · Fixed by #48
Closed

Project Structure #44

mayur-ravindram opened this issue Jan 2, 2022 · 3 comments · Fixed by #48
Assignees
@mayur-ravindram @mohammadkarbalaee
Labels
bug Something isn't working
Projects
jalgorithm v2.0.0

Comments

@mayur-ravindram
Copy link
Contributor

mayur-ravindram commented Jan 2, 2022 •
edited

The project structure is as following (PFA screenshot) when cloned the project.
image
Can we have a project structure pertaining proper java source code? I faced following issues.

  • Project build failed for issues in build.gradle
    image
  • There were no source folders
  • I was not able to add new class/package as source

Pushing changes to update build.gradle file
@mayur-ravindram mayur-ravindram added the bug Something isn't working label Jan 2, 2022
@mayur-ravindram mayur-ravindram added this to in progress in jalgorithm v2.0.0 Jan 2, 2022
@mayur-ravindram mayur-ravindram moved this from in progress to blocked in jalgorithm v2.0.0 Jan 2, 2022
@mayur-ravindram
Copy link
Contributor Author

Blocked due to push access to repo.
@muhammadkarbalaee , pls look into it as discussed.
Will push the code once access issue is resolved.

@mohammadkarbalaee
Copy link
Owner

mohammadkarbalaee commented Jan 2, 2022 •
edited

I opened the push access for collaborators. you can push now. @mayur-ravindram

@mohammadkarbalaee
Copy link
Owner

by the way.... there was a src folder already. you see that.

mayur-ravindram added a commit that referenced this issue Jan 4, 2022
@mayur-ravindram
Issue# 44 - Fixes for building project structure
961350a 
#44
Java Version - 1.8
Gradle version - 7.3.3
@mohammadkarbalaee mohammadkarbalaee linked a pull request Jan 4, 2022 that will close this issue
Bug/issue#44 project structure #48
Merged
@mohammadkarbalaee mohammadkarbalaee moved this from blocked to done in jalgorithm v2.0.0 Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mayur-ravindram mayur-ravindram

@mohammadkarbalaee mohammadkarbalaee

Labels
bug Something isn't working
Projects
jalgorithm v2.0.0
done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bug/issue#44 project structure mohammadkarbalaee/jalgorithm
2 participants
@mayur-ravindram @mohammadkarbalaee