Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: stop using default config when input arg is provided (#290) #291

Merged
merged 1 commit into from
Oct 15, 2021
Merged

fix: stop using default config when input arg is provided (#290) #291

merged 1 commit into from
Oct 15, 2021

Conversation

carlosvini
Copy link
Contributor

Fix #290

muhammadsammy
muhammadsammy approved these changes Oct 15, 2021
View reviewed changes
Copy link
Owner

@muhammadsammy muhammadsammy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thank you!

@muhammadsammy muhammadsammy changed the title fix: default config used by CLI even when input is provided (#290) fix: stop using default config when input arg is provided (#290) Oct 15, 2021
@muhammadsammy muhammadsammy merged commit a25a815 into muhammadsammy:master Oct 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@muhammadsammy muhammadsammy muhammadsammy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CLI doesn't respect input param
2 participants
@carlosvini @muhammadsammy