Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add group prefix #55

Merged
merged 1 commit into from
Sep 17, 2020
Merged

add group prefix #55

merged 1 commit into from
Sep 17, 2020

Conversation

alecf
Copy link
Contributor

@alecf alecf commented Sep 16, 2020

fixes #54

@alecf
Copy link
Contributor Author

alecf commented Sep 16, 2020

FYI, I couldn't figure out how to test this one, but it seemed to follow patterns of what was already in the code

muhammadsammy
muhammadsammy approved these changes Sep 17, 2020
View reviewed changes
Copy link
Owner

@muhammadsammy muhammadsammy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@muhammadsammy muhammadsammy merged commit 52f10eb into muhammadsammy:develop Sep 17, 2020
muhammadsammy added a commit that referenced this pull request Sep 17, 2020
@muhammadsammy
Revert "fix: add group prefix (#55)"
9b0386e 
This reverts commit 52f10eb.
muhammadsammy added a commit that referenced this pull request Sep 17, 2020
@muhammadsammy
Revert "fix: add group prefix (#55)"
b9eeb30 
This reverts commit 52f10eb.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@muhammadsammy muhammadsammy muhammadsammy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

group variant is not prefixed
2 participants
@alecf @muhammadsammy