New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add minTime & minDateTime props to disable period of time #519
Comments
Actually this is a big scope of work - to disable the part of hour. It will not be implemented in the nearest relase. But maybe it would be better to validate this by yourself - and additionally show the error? |
It would be great if |
Woah, thanks for pointing out that it doesn't. I totally assumed it did. |
Any news whether this feature will be implemented? I hope so since it's quite an important requirement in our App. Is the only alternative for now is to overwrite the TextFieldComponent and have the full control of the validation handling? Any suggestions? Thanks :^^ |
This issue is caused by the recent change(b556698). Suggest we can change the DateTimePicker passing a flag => ModalWrapper => DateTextField, if the flag is datetime, don't apply utils.endOfDay and utils.startOfDay when getError(). |
Any feedback about this issue status? |
This issue needs a lot of work. And low priority for us. But if you want you can submit a PR |
Hi, I tried forking this package from the master branch to add this functionality but got the following errors when doing
This is the command that I used: When I opened the |
That’s strange. If you want to contribute checkout CONTRIBUTORS.md |
Any updates regarding this? |
Is there any update on this ? 🧐 |
any news? |
Hi everyone 👋 |
Nice to see that this feature with land in v4. However, is there any good workaround for now? I thought about showing an error message to the user if the selected time is invalid, but how could we achieve that? Of course I'd like to re-use the error label that is generated by the picker itself so that error messages are conistent. |
I got a little workaround for minTime and maxTime, though I couldn't get the component's native error message to trigger, so I created my own. I created a component called CustomTimePicker:
Then I use it like this:
Do your own testing, I created this quickly just now and it seems to be working for me fine. The error message will need some CSS styling to look pretty and it can all probably be improved upon. Cheers. |
I needed a comparision include time so I used date.getTime() compare.. |
any update on this? |
Just a suggestion, I have a case where I need the earliest time selectable to be exactly 24 hours ago.
The text was updated successfully, but these errors were encountered: