Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test] Run more tests in jsdom #1361

Merged
merged 19 commits into from Apr 26, 2021

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Apr 4, 2021

Work on #1151:

We go from 2% of coverage

Screenshot 2021-04-24 at 17 01 30

to 69% of coverage

Screenshot 2021-04-24 at 17 19 45

for tests running in jsdom.


Two issues I didn't spend time on here. I'm breaking them down into two new PRs.

import { LicenseInfo } from '@material-ui/x-grid';

LicenseInfo.setLicenseKey(
  '0f94d8b65161817ca5d7f7af8ac2f042T1JERVI6TVVJLVN0b3J5Ym9vayxFWFBJUlk9MTY1NDg1ODc1MzU1MCxLRVlWRVJTSU9OPTE=',
);

I wouldn't be surprised if this impacts developers in their project too. Not great

@oliviertassinari oliviertassinari force-pushed the react-testing-library branch 4 times, most recently from f39a567 to 935e1df Compare April 4, 2021 23:43
@oliviertassinari
Copy link
Member Author

I have rebased on HEAD.

@oliviertassinari
Copy link
Member Author

@dtassone Ok, done. Please review. This is solving most of the pain in #1151. Regarding closing #1151, maybe what would be left is to add coverage for it in the documentation, maybe in this section: https://material-ui.com/components/data-grid/virtualization/.

@oliviertassinari oliviertassinari merged commit d65c46d into mui:master Apr 26, 2021
@oliviertassinari oliviertassinari deleted the react-testing-library branch April 26, 2021 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants