[DataGrid] Fix performance issue when sorting columns #1368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The fix is working but it is still the thread freezes for a couple of seconds before the sorting finishes. Maybe we can add a loader to indicate that something is happening? But either way, the end-user should be able to perform other actions on the page while the sorting is happening, no? |
oliviertassinari
changed the title
oliviertassinari
added
bug 🐛
There was a problem hiding this comment.
- The performance regression is definitely fixed 👍
- It seems that we might have the opportunity to add a test case here. As far as I remember, it's the second time we break the performance of the sorting (or unless it was the checkbox selection only last time 🤔). Maybe we could render one grid with 1,000 rows, sort it and assert the time it took is x10 below a threshold that HEAD would break?
- Please take the time to detail each pull request. I have dove into the issue to understand and explain what went wrong, to see if there is something we can learn, for the whole team, in the future.
The current issue is in the following call order:
- sorting trigger
- each row calls
api.getCellParams - which calls
getBaseCellParams - which calls
getCellElement - which calls
x.querySelector(y)=> really slow
- the above fix bypass the DOM read.
|
perf is subject to the browser engine so it varies with browsers. |
oliviertassinari
force-pushed
the
sortPerf
branch
from
c8f6000
to
24a6bb2
Compare
oliviertassinari
force-pushed
the
sortPerf
branch
from
24a6bb2
to
d0a7b54
Compare
I have tried something, please review |
Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>
| await waitFor(() => expect(document.querySelector('.MuiDataGrid-sortIcon')).to.not.be.null); | ||
| const t1 = performance.now(); | ||
| const time = Math.round(t1 - t0); | ||
| expect(time).to.be.lessThan(200); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #1330