[DataGrid] Remove use of row.id when id prop is available #1371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtassone
reviewed
Apr 7, 2021
packages/grid/_modules_/grid/hooks/features/filter/gridFilterSelector.ts
Outdated
Show resolved
Hide resolved
dtassone
reviewed
Apr 7, 2021
| return sortedIds.reduce((res, id) => { | ||
| res[id] = idRowsLookup[id]; | ||
| return res; | ||
| }, {} as Record<GridRowId, GridRowModel>); |
There was a problem hiding this comment.
same here. not sure why you refactored the return type
|
Not entirely sure how |
m4theushw
force-pushed
the
remove-row-clone
branch
from
8db1a46
to
20b8522
Compare
m4theushw
changed the title
oliviertassinari
added
component: data grid
oliviertassinari
approved these changes
Apr 11, 2021
dtassone
reviewed
Apr 12, 2021
| @@ -60,6 +60,7 @@ export const GridViewport: ViewportType = React.forwardRef<HTMLDivElement, {}>( | |||
| <GridRowCells | |||
| columns={visibleColumns} | |||
| row={r} | |||
There was a problem hiding this comment.
could we cleanup here please? row?
There was a problem hiding this comment.
dtassone
reviewed
Apr 12, 2021
| @@ -60,6 +60,7 @@ export const GridViewport: ViewportType = React.forwardRef<HTMLDivElement, {}>( | |||
| <GridRowCells | |||
| columns={visibleColumns} | |||
| row={r} | |||
| id={r.id} | |||
There was a problem hiding this comment.
Would that one change with the next PR?
There was a problem hiding this comment.
Yes, the next PR changes to get the id from the Map.
dtassone
reviewed
Apr 12, 2021
| @@ -20,10 +20,15 @@ import { useLogger } from '../../utils/useLogger'; | |||
| import { useGridState } from '../core/useGridState'; | |||
| import { getInitialGridRowState, InternalGridRowsState } from './gridRowsState'; | |||
|
|
|||
| // TODO remove after all row.id are removed | |||
| export function addGridRowId(rowData: GridRowData, getRowId?: GridRowIdGetter): GridRowModel { | |||
m4theushw
force-pushed
the
remove-row-clone
branch
from
20b8522
to
bfc0fe3
Compare
dtassone
approved these changes
Apr 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1119, #1200, #1315
This is the first batch of changes to satisfy the need of removing
idfrom the rowData. In this PR I'm replacingrow.idwith theidprop in all places where it's already available. It has no breaking changes. In the next PR I'll do the rest of the work that requires changes in the API too.