[docs] Update PropType to cover required props #1419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
changed the title
oliviertassinari
force-pushed
the
fix/issue-982
branch
from
326a2a5
to
768ff75
Compare
oliviertassinari
force-pushed
the
fix/issue-982
branch
from
768ff75
to
4285c63
Compare
oliviertassinari
approved these changes
Apr 17, 2021
oliviertassinari
changed the title
oliviertassinari
added
the
component: data grid
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #982. The change improves the DX for developers that have ignored the TypeScript lint errors. It's not a bit easier to recover when not provided the right props:
Also, we sort required props to be first as said in this comment first point.