New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Reshuffle columns and rows styling sections #1622
[docs] Reshuffle columns and rows styling sections #1622
Conversation
I would swap the rows and cell section to keep some kind of hierachy. |
I think so because the purpose is different. In the one from the /demo page, developers are not supposed to look at the source. It will grow as a mess (overwhelming to learn anything in the code side) as we make it full-featured. |
I would rename demo to Theme |
I agree that the current header name feels off. To some extent, it makes sense to call it "Theme" as we have talked about using the Maybe we could call it like the customization demos in the core components? For instance https://next.material-ui.com/components/checkboxes/#customized-checkbox |
I agree, the demo feels off as we already have a demo on another page. I would change it to "Customized demo" (single) and if we add more we can have sections and rename it to "Customized demos" |
Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>
…e/DataGrid-1496-update-style-page-docs
Fixes #1496
Sections already existed so this was more of combining them in a single page.
Things I'm not sure about:
columns
we have 2 separate sections but forrows
there is only one,https://deploy-preview-1622--material-ui-x.netlify.app/components/data-grid/style/