Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Reshuffle columns and rows styling sections #1622

Merged

Conversation

DanailH
Copy link
Member

@DanailH DanailH commented May 11, 2021

Fixes #1496

Sections already existed so this was more of combining them in a single page.

Things I'm not sure about:

  • The right side nav structure - for columns we have 2 separate sections but for rows there is only one,
  • Do we still need the demo? I've moved it to the bottom of the page. Technically it is a duplicate because the same can be found on the Demo page
  • Should update the examples?

https://deploy-preview-1622--material-ui-x.netlify.app/components/data-grid/style/

@DanailH DanailH added the docs Improvements or additions to the documentation label May 11, 2021
@DanailH DanailH self-assigned this May 11, 2021
@dtassone
Copy link
Member

I would swap the rows and cell section to keep some kind of hierachy.

@oliviertassinari
Copy link
Member

oliviertassinari commented May 11, 2021

Do we still need the demo? I've moved it to the bottom of the page. Technically it is a duplicate because the same can be found on the Demo page

I think so because the purpose is different. In the one from the /demo page, developers are not supposed to look at the source. It will grow as a mess (overwhelming to learn anything in the code side) as we make it full-featured.

@dtassone
Copy link
Member

@oliviertassinari
Copy link
Member

oliviertassinari commented May 11, 2021

I would rename demo to Theme
https://deploy-preview-1622--material-ui-x.netlify.app/components/data-grid/style/#demo

I agree that the current header name feels off. To some extent, it makes sense to call it "Theme" as we have talked about using the theme to implement this customization demo. On the other hand, developers might expect something they can directly import if we can it "Theme", which we don't provide, it's only a customization demo.

Maybe we could call it like the customization demos in the core components? For instance https://next.material-ui.com/components/checkboxes/#customized-checkbox

@oliviertassinari oliviertassinari added the component: data grid This is the name of the generic UI component, not the React module! label May 11, 2021
@DanailH
Copy link
Member Author

DanailH commented May 12, 2021

I agree, the demo feels off as we already have a demo on another page. I would change it to "Customized demo" (single) and if we add more we can have sections and rename it to "Customized demos"

DanailH and others added 2 commits May 12, 2021 14:50
Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>
@DanailH DanailH requested a review from dtassone May 12, 2021 12:59
@DanailH DanailH merged commit 7215bc6 into mui:master May 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: data grid This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[docs] Update the style page to illustrate how to style rows, cell and column headers
3 participants