[docs] Clean demos components #1681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
force-pushed
the
docs-clean-demos
branch
from
51bc954
to
689277f
Compare
dtassone
reviewed
May 17, 2021
| color={color} | ||
| variant="outlined" | ||
| onClick={(event) => { | ||
| event.stopPropagation(); |
There was a problem hiding this comment.
why do you need to stop propagation here? Next js issue?
There was a problem hiding this comment.
I have stopped the propagation to keep the column menu open when we toggle the button.
AFAIK, we have never seen a rendering issue from Next.js. I don't know what would put us on this lead, it uses the public React API, so I doubt it will ever happen. I believe we can reproduce the flash on codesandbox
There was a problem hiding this comment.
No I just wondered... Maybe it is worth adding a comment.
The next js idea was total supposition.
dtassone
approved these changes
May 17, 2021
|
Ready to go? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A follow-up on #1382. Preview: https://deploy-preview-1681--material-ui-x.netlify.app/components/data-grid/components/