Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DataGrid] Fix CSS classes prefix #1693

Merged
merged 1 commit into from May 18, 2021
Merged

[DataGrid] Fix CSS classes prefix #1693

merged 1 commit into from May 18, 2021

Conversation

m4theushw
Copy link
Member

@m4theushw m4theushw commented May 18, 2021 •
edited by oliviertassinari

The column resizing and column reordering were not working.
Preview: https://deploy-preview-1693--material-ui-x.netlify.app/components/data-grid/#commercial-version

Broken in #1660

@m4theushw m4theushw requested a review from DanailH May 18, 2021 12:34
@oliviertassinari
Copy link
Member

oliviertassinari commented May 18, 2021 •
edited

Off-topic

If we could drop these consts to reproduce the dataGridClasses pattern we have with the other components, I think that it would be great. I have stored the feedback in #408 (comment).

@m4theushw m4theushw merged commit 5d7984f into mui:master May 18, 2021
@m4theushw m4theushw deleted the fix-css-classes branch May 18, 2021 13:53
@zannager zannager added the component: data grid This is the name of the generic UI component, not the React module! label Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtassone dtassone dtassone approved these changes

@DanailH DanailH DanailH approved these changes

Assignees
No one assigned
Labels
component: data grid This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@m4theushw @oliviertassinari @dtassone @DanailH @zannager