Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[XGrid] Display the number of filtered rows in the footer #1830

Merged
merged 2 commits into from Jun 8, 2021

Conversation

m4theushw
Copy link
Member

@m4theushw m4theushw commented Jun 5, 2021

Fixes #1802

Preview: https://deploy-preview-1830--material-ui-x.netlify.app/components/data-grid/filtering/#multi-column-filtering

Capture d’écran 2021-06-14 à 02 09 38

I'm only displaying the number of filtered rows when the pagination is disabled.

DataTables also displays it in the pagination:

image

Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great

packages/grid/_modules_/grid/components/GridRowCount.tsx Outdated Show resolved Hide resolved
Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm leaving as a review as I have opened the issue we go after. It delivers

@m4theushw m4theushw merged commit f5221ef into mui:master Jun 8, 2021
@m4theushw m4theushw deleted the filtered-rows-count branch June 8, 2021 11:58
@oliviertassinari
Copy link
Member

I'm only displaying the number of filtered rows when the pagination is disabled.

We didn't solve the problem with server-side filtering: https://material-ui.com/components/data-grid/filtering/#server-side-filter either but it's probably not important.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[XGrid] When filtering, should display the number of filtered rows
3 participants