[test] Test vertical scrollbar #1932
Conversation
|
Ok, I got the screenshot test to fail as expected:
The function test is not failing however, the events fire twice. It seems that triggering this problem is actually hard. AFAIK we don't have any test case for the scrollbar, so these new ones won't harm. |
| // A function test counterpart of ScrollbarOverflowVerticalSnap. | ||
| it('should not have a horizontal scrollbar if not needed', () => { | ||
| const TestCase = () => { | ||
| const data = useData(100, 1); |
There was a problem hiding this comment.
this is a simple case. The test should cover when we have the total column width that is within the container width - scroll width ie
container width of 500, total column width of 495 no scroll bar if no vertical scrollbar, also we could check with a total width of 485 so no scroll bar even if there is a vertical one
Does that make sense?
There was a problem hiding this comment.
This is interesting but outside of the scope of the problem I'm trying to solve. It can be a new test case in another PR. This one is as simple as possible, while still enough to catch the regression we were close to release.
|
Ok, so now, if somebody try to apply the changes I did in #1831, the CI will fail. |
Add a test case for #1831 (comment). We could have easily missed it. I have added a visual and function test base the functional test is flaky to catch the issue. The order of resolution between the two effects varies.