[core] Add @material-ui/lab as peer dependency #2012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think we want to do the same for |
flaviendelangle
approved these changes
Jul 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1878
Noticed while debugging #1993 that demos depending in
@material-ui/x-grid-data-generatorwon't work with MUI v5 because the version of the lab is fixed in v4. This PR makes the lab a peer dependency.Before: https://codesandbox.io/s/material-demo-forked-1vzw6?file=/package.json
After: https://codesandbox.io/s/material-demo-forked-nzqjp?file=/package.json
I'm aware that clicking in any cell to edit crashes the demo. I'll fix this in another PR. The first step was to make them at least run with v5.