[XGrid] Fix column resize on touch devices #2089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m4theushw
changed the title
m4theushw
force-pushed
the
column-resize-regression
branch
from
a82cc39
to
8ea4ff6
Compare
m4theushw
added
regression
DanailH
approved these changes
Jul 7, 2021
There was a problem hiding this comment.
When do we remove this line? https://github.com/mui-org/material-ui-x/pull/1989/files#r664813310
m4theushw
force-pushed
the
column-resize-regression
branch
from
8ea4ff6
to
d1732e3
Compare
| @@ -36,6 +37,10 @@ let cachedSupportsTouchActionNone = false; | |||
| // Over 80% of the iOS phones are compatible | |||
| // in August 2020. | |||
| function doesSupportTouchActionNone(): boolean { | |||
| // The document is not defined in the server-side | |||
| if (typeof document === 'undefined') { | |||
There was a problem hiding this comment.
I wonder if we will need an abstraction from the utils package to determine if we are on the server or not. Sometimes poeple add global and break our heuristics. e.g. https://github.com/mui-org/material-ui/blob/0230df94ca877fdd63a42c3e276f75c3a4316eea/packages/material-ui-utils/src/useEnhancedEffect.js#L3. Anyway, not important.
There was a problem hiding this comment.
I'm checking the document because it's the most obvious ("document is not defined" error), but all code examples I found in StackOverflow to fix this problem looks at the window. I'll leave as it is.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2007
Preview: https://deploy-preview-2089--material-ui-x.netlify.app/components/data-grid/demo/