Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript version of React-Select Autocompletion implementation #10508

Closed
franklixuefei opened this issue Mar 3, 2018 · 3 comments
Closed

Comments

@franklixuefei
Copy link
Contributor

Hi,

I think that the React-Select autocompletion implementation under Autocompletion page is out-dated. Could you please review and update it? Also, currently I'm using typescript, and I'm having really hard time figuring out how to convert your implementation to typescript. Could you help me with that?

Thanks!

@oliviertassinari
Copy link
Member

oliviertassinari commented Mar 3, 2018

I think that the React-Select autocompletion implementation under Autocompletion page is out-dated.

@franklixuefei What makes you think the demo is outdated? It seems to work: https://codesandbox.io/s/py61x4kz3j.

currently I'm using typescript, and I'm having really hard time figuring out how to convert your implementation to typescript. Could you help me with that?

No, I can't. You can always refer to our TypeScript and the react-select TypeScript support.

@mui mui deleted a comment from fabijanski Mar 3, 2018
@franklixuefei
Copy link
Contributor Author

franklixuefei commented Mar 4, 2018

@oliviertassinari Thanks Olivier. It seems like the typescript definition for React-Select is not consistent with its implementation. I think I'll just fall back to Mui Multiple Selection in the demo here - https://material-ui.com/demos/selects/. However, for multiple selection, do you know how I can enable key stroke selections? Like if I start typing the first few letters of an option after the dropdown is expanded, that option can be highlighted, just like what's in the native selection.

Actually, I've also tried adding "native" property to Select in the multiple select demo, but after that, the dropdown stops showing up anymore... (https://codesandbox.io/s/618yp103q3)

So my questions are:

  1. Can keystroke highlighting be supported in the multiple Select?
  2. Can I enable native with multiple together?

Thanks!

@oliviertassinari
Copy link
Member

oliviertassinari commented Mar 4, 2018

Can keystroke highlighting be supported in the multiple Select?

No: #8191

Can I enable native with multiple together?

Humm, last time I checked, the native select support of multiple is strange. I haven't tried it with Material-UI. It will most likely not work.

We have sorted the demos by order of quality. The react-select is at the last position. I would rather not plan any work on it. At least, until the beta gets out. They are reimplementing the component from scratch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants