New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TransferList] Add new component #15232
[TransferList] Add new component #15232
Conversation
No bundle size changes comparing f1e2e55...4a32c2f |
What do you think of
|
Maybe creating a new section to differentiate it from base components as well? |
You can have only two buttons if you like – it's addressed in the demo description. Why not provide useful code that can be omitted, rather than omitting it and it having to be recreated if required? I don't believe the list component has the concept of a "select-all" checkbox. The double chevron is a common pattern; also, one click vs. two.
Then it becomes a component in its own right, needing tests and types. It's a simple, well structured demo (compared to some of the monoliths we have adopted), and is directly related to lists. If someone wants to run with it and give it a bunch of features, be my guest. |
@mbrookes I'm not sure we are on the same page:
https://element.eleme.io/#/en-US/component/transfer#transfer https://ant.design/components/transfer/#header http://uxco.re/components/transfer/ I can find very little component to benchmark against 😔. |
I would support this philosophy. The alternate implementations do not have the functionality of transfering all items. |
List and Button (and Checkbox). It's a slightly more advanced list example. But if the goal is to boost the perceived number of components supported, then sure, it could have its own page.
Fair point.
You can in a couple of @oliviertassinari's examples by using the "select-all" checkbox before transferring. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice start! :)
Co-Authored-By: mbrookes <github@nospam.33m.co>
Co-Authored-By: mbrookes <github@nospam.33m.co>
Here are a few more (some dated) examples. (I also found the ones you found. 🍒:wink: ). Most use the double chevron for move all, though a couple don't offer any move-all feature. https://github.com/RickStrahl/vue-mover http://uxco.re/components/transfer/ https://codinginthetrenches.com/2014/05/24/create-an-object-based-dual-list-shuttle-with-knockoutjs/ https://docs.oracle.com/cd/E29049_01/web.1112/e16182/lists.htm https://xdsoft.net/jquery-plugins/shuttle/ So let's do a demo for both move-all and select-all 😄 : I also came across the wikipedia definition: |
4379a2c
to
ff0633b
Compare
f9c60b5
to
80285dc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love it :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was too lazy to report it. Nice fix!
Okay, done tweaking. :) |
We need a good framework for finding the components that are the most requested by our users. This transfer list component is not a highly requested one, but it's always nice to have it :). We can always defer it somewhere else in the future if it's slowing us down and if relatively little people use it. @mbrookes well done :) |
Preview: https://deploy-preview-15232--material-ui.netlify.com/demos/transfer-list/