Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

yarn docs:api is removing <br> tags #15657

Closed
2 tasks done
joshwooding opened this issue May 10, 2019 · 4 comments 路 Fixed by #16165
Closed
2 tasks done

yarn docs:api is removing <br> tags #15657

joshwooding opened this issue May 10, 2019 · 4 comments 路 Fixed by #16165
Labels
bug 馃悰 Something doesn't work external dependency Blocked by external dependency, we can鈥檛 do anything about it

Comments

@joshwooding
Copy link
Member

joshwooding commented May 10, 2019

  • This is not a v0.x issue.
  • I have searched the issues of this repository and believe that this is not a duplicate.

Expected Behavior 馃

yarn docs:api keeps <br> tags

Current Behavior 馃槸

yarn docs:api is removing <br> tags

Steps to Reproduce 馃暪

Link: joshwooding@65a31b0

  1. Run yarn docs:api

Context 馃敠

I think it's a windows only bug. I assume it stems from the new defaultPropsHandler

@joshwooding joshwooding added bug 馃悰 Something doesn't work core labels May 10, 2019
@eps1lon
Copy link
Member

eps1lon commented May 11, 2019

I think it's a windows only bug. I assume it stems from the new defaultPropsHandler

Can you run a git bisect to verify (don't forget to yarn install between steps)? It shouldn't touch the description just the default values which isn't affected in the diff.

@joshwooding
Copy link
Member Author

joshwooding commented May 11, 2019

Can you run a git bisect to verify (don't forget to yarn install between steps)? It shouldn't touch the description just the default values which isn't affected in the diff.

Yeah, This issue was mainly so I didn't forget :P I'm running the git bisect now. I've had a look at the handler and it confuses me too. Saying it might have stemmed from the new handler also meant that maybe the react-docgen change caused it.

@eps1lon
Copy link
Member

eps1lon commented May 11, 2019

Yeah bisect won't help with this since we upgraded in the same commit. I guess you could just remove the handler (there's some concat(muiDefaultPropsHandler)) and see if this helps.

@joshwooding
Copy link
Member Author

Looks like it's due to the new react-docgen version. I've run through git bisect and it points to the upgrade commit and the problem still exists when you remove the defaultPropsHandler.

@joshwooding joshwooding added the external dependency Blocked by external dependency, we can鈥檛 do anything about it label May 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 馃悰 Something doesn't work external dependency Blocked by external dependency, we can鈥檛 do anything about it
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants