Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Badge CSS api types don't include colorError #15773

Closed
2 tasks done
keycad opened this issue May 21, 2019 · 5 comments
Closed
2 tasks done

Badge CSS api types don't include colorError #15773

keycad opened this issue May 21, 2019 · 5 comments
Labels
component: badge This is the name of the generic UI component, not the React module! good first issue Great for first contributions. Enable to learn the contribution process. typescript

Comments

@keycad
Copy link

keycad commented May 21, 2019

  • This is not a v0.x issue.
  • I have searched the issues of this repository and believe that this is not a duplicate.

Expected Behavior 馃

When customizing a Badge component, colorError should be available, as explained in the docs (https://material-ui.com/api/badge/)

Current Behavior 馃槸

colorError is not available in the types, just the following:

export type BadgeClassKey =
  | 'root'
  | 'badge'
  | 'colorPrimary'
  | 'colorSecondary'
  | 'invisible'
  | 'dot';

Your Environment 馃寧

Tech Version
Material-UI core v3.9.3
TypeScript 3.2.2
@eps1lon eps1lon added component: badge This is the name of the generic UI component, not the React module! typescript good first issue Great for first contributions. Enable to learn the contribution process. labels May 21, 2019
@eps1lon
Copy link
Member

eps1lon commented May 21, 2019

@keycad
Copy link
Author

keycad commented May 21, 2019

thanks @eps1lon ! Should I expect a new 3.9... release including this?

@ubaidisaev
Copy link

This problem is already solved. We need to close it.

@joshwooding
Copy link
Member

@ubaid-dev Thanks 馃憤 Fixed in #15581

@keycad
Copy link
Author

keycad commented Jun 3, 2019

thanks @eps1lon ! Should I expect a new 3.9... release including this?

can anyone tell me if it will be available in a 3.x.y version?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: badge This is the name of the generic UI component, not the React module! good first issue Great for first contributions. Enable to learn the contribution process. typescript
Projects
None yet
Development

No branches or pull requests

4 participants