Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ripples are triggered on mouseup instead of mousedown. #19

Closed
jklein24 opened this issue Nov 9, 2014 · 0 comments
Closed

Ripples are triggered on mouseup instead of mousedown. #19

jklein24 opened this issue Nov 9, 2014 · 0 comments
Labels
bug 🐛 Something doesn't work

Comments

@jklein24
Copy link

jklein24 commented Nov 9, 2014

Ripples should trigger on mousedown. See:

https://www.polymer-project.org/components/paper-ripple/demo.html
@hai-cea hai-cea added the bug 🐛 Something doesn't work label Nov 9, 2014
@jklein24 jklein24 changed the title Ripples are triggered on keyup instead of keydown. Ripples are triggered on mouseup instead of mousedown. Nov 9, 2014
mnajdova referenced this issue in mnajdova/material-ui Nov 10, 2020
@oliviertassinari @eps1lon
[DatePicker] Squash compat commits
0b069d9 
Move picker sources into lab (#4)

Update README.md

[DatePicker] Refactor pickers tests to testing-library and mocha (#5)

[TimePicker] Migrate tests to testing library (#8)

[DateTimePicker] Migrate tests  (#9)

Fix all pickers linter errors (#10)

Fix all circular dependencies (#11)

* Fix all circular dependencies

* Enable mocha eslint rules for typescript tests

[test] The last step to a green CI (#15)

Migrate pickers docs (#12)

Downgrade to withStyles for pickers sources (#16)

Add public api exports for pickers components (#17)

Consolidate component namespace and theme augmentation  (#18)

Describe conformance for pickers sub-components (#19)

Autogenerate proptypes for typescript sources  (#20)

Proper build output (#21)

Clear migration artifacts  (#23)

Eslint rule for lower-case test name convention  (#24)

DateRangePicker  (#25)

yarn deduplicate

Remove GridListTile

[DateTimePicker] Fix migration unit tests

Fix types

Fix typescript types migration issues

Fix yarn lerna build (#33)

Fix karma tests

use window.Touch for CI karma tests

Remove more outdated diff noise (#34)

Replace not valid formats with valid ISO strings

Try to fix CI touch tests

Skip tests if Touch events are not supported

Fix merge conflicts

Actually type-check

Fix safari tests

Remove lowercase test name rule

The casing is up to the test author.
We're not the grammar police in tests.

Fix lint

Format

Remove overzealous eslint-disable*

Debug failing tests

Better debugging

Timezones are fun

was isoString th efix?

Let's find out what's failing and then skip it

Branch for safari

Skip DateRangePicker in browsers

review

Matt's review

Co-authored-by: Matt <github@nospam.33m.co>

format

docs:i18n
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug 🐛 Something doesn't work
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jklein24 @hai-cea