[docs] Improve _app usage in nextjs examples #20381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HaNdTriX
force-pushed
the
next-app-functional
branch
from
cf3ed29
to
c5aa16b
Compare
HaNdTriX
changed the title
HaNdTriX
force-pushed
the
next-app-functional
branch
from
c5aa16b
to
3aeb975
Compare
HaNdTriX
changed the title
Details of bundle changes.Comparing: 549bc5c...0aa9604 Details of page changes
|
HaNdTriX
force-pushed
the
next-app-functional
branch
from
3aeb975
to
d49f20d
Compare
HaNdTriX
changed the title
HaNdTriX
changed the title
eps1lon
changed the title
|
@HaNdTriX Cool. I wasn't aware that we no longer have to extend |
| @@ -1,34 +1,30 @@ | |||
| import React from 'react'; | |||
| import App from 'next/app'; | |||
| import React, { useEffect } from 'react'; | |||
There was a problem hiding this comment.
import React from 'react';
| import { ThemeProvider } from '@material-ui/core/styles'; | ||
| import CssBaseline from '@material-ui/core/CssBaseline'; | ||
| import theme from '../src/theme'; | ||
|
|
||
| export default class MyApp extends App { | ||
| componentDidMount() { | ||
| export default function MyApp({ Component, pageProps }: AppProps) { |
There was a problem hiding this comment.
export default function MyApp(props: AppProps) {
| // Remove the server-side injected CSS. | ||
| const jssStyles = document.querySelector('#jss-server-side'); |
There was a problem hiding this comment.
const jssStyles = document.querySelector('#jss-server-side');
3 tasks
This was referenced Apr 6, 2020
This was referenced Apr 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
examples/nextjs-_.app.jsMigrate to use functional componentexamples/nextjs-_.app.jsAdd prop-typesexamples/nextjs-with-typescript-_.app.js: Migrate to use functional component