[docs] Fix warning and crash in dev mode #20623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
force-pushed
the
docs-fix-pages-with
branch
from
317e525
to
6a20a9b
Compare
|
No bundle size changes comparing 72a477f...71f9f5e |
github-actions
bot
added
PR: out-of-date
oliviertassinari
force-pushed
the
docs-fix-pages-with
branch
from
6a20a9b
to
71f9f5e
Compare
oliviertassinari
added
PR: ready to ship
and removed
PR: out-of-date
eps1lon
reviewed
Apr 21, 2020
| @@ -10,6 +10,10 @@ const requireRaw = require.context( | |||
| /\.(js|md|tsx)$/, | |||
| ); | |||
|
|
|||
| // Run styled-components ref logic | |||
There was a problem hiding this comment.
They test that calling useRef crashes, however, we call it inside a React render method, hence, it warns.
There was a problem hiding this comment.
So it's not about "ref logic" but rather about where we instantiate the module (they could use any hook. useRef is just the fasted). Doing it during render triggers a false alarm in styled-components.
There was a problem hiding this comment.
Yes, you are right
There was a problem hiding this comment.
Yes, you are right
This was referenced Apr 29, 2020
This was referenced May 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The crash can be reproduced on http://0.0.0.0:3000/components/autocomplete. I have seen warnings on these pages for a few months.
Related to styled-components/styled-components#2998