[docs] Replace react-frame-component with concurrent safe impl #20677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Details of bundle changes.Comparing: 76f5f91...14578ec Details of page changes
|
|
@eps1lon You are not going to like this:
From what I recall, we had this issue or a very similar one in the past with Firefox only. We solved it by injecting the styles inside the body instead of the head. |
That would be very suspicious to me. Right now it doesn't even work without injecting any styles. |
How do you decide when to use which? |
new: makeStyles, old: withStyles. Refactoring happens when you're already working on the code. |
Ah okay. But presumably this doesn’t apply to components because of things like |
Yeah. But all of these could be solved. It's just not necessarily worth it considering we want to switch to styled-components. I'm not looking forward to having wrappers all over the place again but that's a dev-tooling issue. |
This was referenced Apr 29, 2020
This was referenced May 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
react-frame-componentcallsdocument.writeduring render which isn't concurrent mode safe (see ryanseddon/react-frame-component#159). It's also unnecessary since they falsely assume portaling intodocument.bodyis unsafe because it's unsafe forrender().createPortal()andrender()have different semantics.It also has a lot of logic that we no longer need as of . Since it seems to not be maintained anymore (months old unanswered issues/prs, testing on node 6 etc) we it's not clear if these issues get addressed.
Also switches from withStyles to makeStyles
Related to #13394