[core] Batch small changes #20823
Merged
[core] Batch small changes #20823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The /pt/ is the most used locale used, it's also the most transalted, almost 100%. It seems safe to enable auto redirection for this locale.
freeSolo has two main use cases, make it explicit.
oliviertassinari
added
the
umbrella
Details of bundle changes.Comparing: 0ce7487...03d3b2f Details of page changes
|
|
@eps1lon There is another issue with the notification I didn't mention: it throws when clicking before the XHR request is resolved (It's a regression I have introduced).
|
github-actions
bot
added
the
PR: out-of-date
oliviertassinari
removed
the
PR: out-of-date
joshwooding
reviewed
Apr 28, 2020
| (count, message) => (message.id > lastSeen ? count + 1 : count), | ||
| 0, | ||
| ); | ||
| const messageList = messages |
There was a problem hiding this comment.
Suggested change
| const messageList = messages | |
| const messageList = Array.isArray(messages) |
?
There was a problem hiding this comment.
What's the advantage?
There was a problem hiding this comment.
It’s more explicit but ultimately doesn’t need to happen.
| }); | ||
| document.cookie = `lastSeenNotification=${messageList[0].id};path=/;max-age=31536000`; | ||
|
|
||
| if (messageList) { |
There was a problem hiding this comment.
All though it shouldn't happen if this is an empty array below will still throw.
Suggested change
| if (messageList) { | |
| if (messageList && messageList.length > 0) { |
| <Badge | ||
| color="secondary" | ||
| badgeContent={ | ||
| messageList |
There was a problem hiding this comment.
You could use Array.isArray here too :) I won't point out the others
This was referenced May 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close the developer survey 42c32dc: The survey has been running for 22 days, we had 1,450 answers, x2 more than last year. It's probably time to close it. We have to analyze the results now 😅.
[l10n] Improve fr-FR value 16bdb64: Thanks @raduchiriac for the report in 9c053f8#r38650085.
[docs] Automatically redirect pt to pt-BR 611a655: as discussed with @jaironalves, the
/pt/locale is the most used one. It's also the most translated, at almost 100%. It seems safe to enable auto redirection for this locale, as we have for the Chinese one.Legend
Language=> the primary configured language of the browseruserLanguage=> the language of the docs[Autocomplete] Improve the heading structure cea1d62: freeSolo has two main use cases, make it explicit.
[core] Most of the time, we use aria-hidden as a boolean a4ec727: a nitpick.
[l10n] Fix dark mode support of the demo a638ef8: reported by @dtassone on
https://material-ui.com/guides/localization/#example
[docs] Add a new introduction series of videos ee96096: New up-to-date quality content is always appreciated, thanks @AtotheY.
[docs] Warn about the a11y implication of changing HTML font size bee571e: ♿️
[Autocomplete] Use useControlled instead of custom logic 3f0bed0: I believe there is another case to migrate: the Rating, for another time.
[docs] Fix centering of code on mobile 7e64043: a small display bug, it's not centered.
[docs] Display a loading state for notifications 18bee68: display a loader instead of an empty state, it also throws an exception.
master:
