[styles] Improve component props inference of styled #20830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Details of bundle changes.Comparing: 5627473...7b2b408 Details of page changes
|
eps1lon
requested changes
Apr 29, 2020
|
Yes sure. |
eps1lon
added
the
package: styles
eps1lon
reviewed
Apr 29, 2020
| const renderedMyComponent = ( | ||
| <React.Fragment> | ||
| <MyComponent className="test" /> | ||
| <StyledMyComponent theme={MyThemeInstance} /> | ||
| <StyledInferedPropsMyComponent defaulted="Hi!" className="test" /> |
There was a problem hiding this comment.
This is an issue. className isn't required. It should pass without it.
There was a problem hiding this comment.
Have you looked at source?
There was a problem hiding this comment.
I have got about what you.
className is required by MyComponentProps. Non required className is overridden by this.
There was a problem hiding this comment.
I have changed it but I am not sure, should we change original props?
oliviertassinari
changed the title
eps1lon
approved these changes
Apr 29, 2020
|
@vlazh Thanks |
This was referenced May 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes allow using props with type checking in
ComponentCreator:Without that changes a ts error occurs:
Property 'status' does not exist on type '{ theme: DefaultTheme; }'.ts(2339)