[styles] Return simpler type from ComponentCreator #20854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Details of bundle changes.Comparing: 0cd5819...9bae8f2 Details of page changes
|
eps1lon
reviewed
Apr 30, 2020
eps1lon
requested changes
May 4, 2020
|
Unfortunately I have mistaken. It still not working. // Infering props from another component to correct type checking.
// Use `Omit` just for make type objectable to avoid `Rest types may only be created from object types.ts(2700)` error
// in `ComponentWrapper`.
// If you remove Omit or something else many things will not work with TS.
type ComponentWrapperProps<C extends React.ElementType = any> = Omit<
{ component?: C } & (undefined extends C ? unknown : React.ComponentProps<C>),
never
>;
// Component that accept another component in order to do some manipulations with that component.
// Same technique uses in MUI AFAIK
function ComponentWrapper<C extends React.ElementType = 'div'>({
component = 'div' as C,
...rest
}: ComponentWrapperProps<C>): JSX.Element {
console.log(rest);
// some logic
return React.createElement(component);
}
// Using with correct inferred props
<ComponentWrapper component={StyledInferedPropsMyComponent} defaulted="def" />;But in this case we get error:
Why |
The problem is I think it might be best to switch from |
Let's try. I have changed it. |
eps1lon
reviewed
May 5, 2020
|
Done. |
eps1lon
approved these changes
May 5, 2020
eps1lon
changed the title
|
@vlazh Perfect, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I use
styledcomponent like this:I get TS error:
because TS can't assign
FunctionComponenttoComponentClassand vise versa.So in that situation we need concreate stable component type. I have look at the source of
styledand found usingforwardRef.