-
-
Notifications
You must be signed in to change notification settings - Fork 31.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Label accessibility for native select #20876
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Details of bundle changes.Comparing: 4bfcbec...fe5d011 Details of page changes
|
mkesavan13
changed the title
[Documentation Update] Select Native Accessibility label
[docs] Select Native Accessibility label
May 2, 2020
oliviertassinari
changed the title
[docs] Select Native Accessibility label
[docs] Label accessibility for native select
May 3, 2020
oliviertassinari
approved these changes
May 3, 2020
oliviertassinari
added
accessibility
a11y
component: select
This is the name of the generic UI component, not the React module!
labels
May 4, 2020
eps1lon
approved these changes
May 4, 2020
@mkesavan13 Much appreciated, thanks! |
@eps1lon & @oliviertassinari - I am glad to help. Thanks for accepting the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
accessibility
a11y
component: select
This is the name of the generic UI component, not the React module!
docs
Improvements or additions to the documentation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
<Select native/>
<Select native/>
is detected in Chrome's lighthouse only when thehtmlFor
attribute is added to<InputLabel/>
Declaration