[docs] Fix leaking lazy stylesheets #20903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Details of bundle changes.Comparing: f7e6cb6...4e3c142 Details of page changes
|
| styleNode.parentElement.removeChild(styleNode); | ||
| }; | ||
| }, []); | ||
| useLazyCSS('https://cdn.jsdelivr.net/docsearch.js/2/docsearch.min.css', '#app-search'); |
There was a problem hiding this comment.
If we take the case of a page transition between /components/speed-dial/ -> /components/rating/ we remove the CSS of Algolia to append them back a few ms later (it doesn't happen for the other assets). We could wonder:
Should we be worried about removing and appending CSS a few ms later?
There was a problem hiding this comment.
Should we be worried about removing and appending CSS a few ms later?
What are you worried about?
There was a problem hiding this comment.
It's more my curiosity speaking than any of my fears. I'm curious to better understand how the CSS engine performs.
I imagine the concern is close to: What's wrong with leaking a few CSS files? I assume it boils down to improving the performance of the page. I don't have enough knowledge of how the CSS engine performs to tell. I thought that it was interesting to raise the side effect with the Algolia search for a page transition.
There was a problem hiding this comment.
What's wrong with leaking a few CSS files?
We're not leaking anything here. We're actually leaking less. The docsearch css is reloaded on master as well.
There was a problem hiding this comment.
I just realized: This change didn't even change anything for algolia. Any behavior you see related to docsearch.min.css happens on master as well.
For the prism css it's more of a precaution in case we ever unmount it.
oliviertassinari
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We didn't consistently clean up the create
<link />elements. Fixed it in the demos and created a separate hook that prevents incorrect usage.