-
-
Notifications
You must be signed in to change notification settings - Fork 31.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Add missing spot do DiamondSponsors #20958
Conversation
@@ -163,7 +163,7 @@ function AppDrawer(props) { | |||
</div> | |||
<Divider /> | |||
<Box mx={3} my={2}> | |||
<DiamondSponsors /> | |||
<DiamondSponsors spot="drawer" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, was planned in the next batch :) https://trello.com/c/Eifr9U6q/2580-diamondsponsors-add-spotsidenav
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No worries. Was just a bit irritating when investigating StrictMode warnings 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So do you prefer "sidenav"? I don't think we used this name before.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have used sidenav
in the first report shared to Sencha. No specific preference.
Details of bundle changes.Comparing: 9988b6b...a5a5e26 Details of page changes
|
Although we now only use it once we should keep the spot tracking in case we later use it somewhere else. We might forget to add it then.
Otherwise we should inline the component and add warning to add spot tracking once we export it again.