[docs] Reduce likelyhood of overflow in ToC #20961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Details of bundle changes.Comparing: 23f984e...ab34d2b Details of page changes
|
| @@ -36,16 +36,17 @@ const useStyles = makeStyles((theme) => ({ | |||
| }, | |||
| item: { | |||
| fontSize: 13, | |||
| padding: theme.spacing(0.5, 0, 0.5, 1), | |||
There was a problem hiding this comment.
What about restoring this style? There is an issue with the vertical spacing between the items. There isn't enough space to read/scan each item individually and understand how the text is grouped when it wraps.
There was a problem hiding this comment.
If we're interested in readability I went with line-height and also used rem instead of a fixed size. Before we couldn't scale the readability.
oliviertassinari
approved these changes
May 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Especially function signatures are very likely to cause overflow since they can include two words that aren't breakable:
functionNameIsTheFirst(andTheFirstArgIsTheSecondName. We now add a zero-width space after an opening paren that is from a function signature (i.e. a word that is followed by an opening paren).This also aligns the ToC to the grid by using theme.spacing(1) instead of 1.5.
Before: https://material-ui.netlify.app/customization/theming/#theming
After: https://deploy-preview-20961--material-ui.netlify.app/customization/theming/#theming
