Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[styles] Increase counter only for non global styles #21003

Merged
merged 2 commits into from
May 14, 2020
Merged

[styles] Increase counter only for non global styles #21003

merged 2 commits into from
May 14, 2020

Conversation

jantimon
Copy link
Contributor

I have an idea to reduce the ruleCounter amount but maybe I didn't fully understand the idea behind increasing the ruleCounter.

Right now all styles also those which are not using the ruleCounter are increasing the counter.

This PR increases the counter only once it is used.

@mui-pr-bot
Copy link

mui-pr-bot commented May 12, 2020 •
edited

Details of bundle changes.

Comparing: e25b7d5...3e5e1fa

Details of page changes
bundle Size Change Size Gzip Change Gzip
/components/skeleton ▼ -100 B (-0.98% ) 10.1 kB -- -1 B
/api-docs/grid-list-tile-bar ▲ +10 B (+0.56% ) 1.8 kB -- -1 B
/api-docs/grid-list-tile ▼ -10 B (-0.58% ) 1.72 kB -- -1 B
/api-docs/grid-list ▲ +10 B (+0.62% ) 1.62 kB -- -1 B
/api-docs/menu ▼ -10 B (-0.41% ) 2.4 kB -- -1 B
/blog/october-2019-update ▼ -10 B (-0.40% ) 2.5 kB -- -1 B
/components/pickers ▼ -10 B (-0.17% ) 6 kB -- -1 B
/customization/density ▼ -10 B (-0.10% ) 9.75 kB -- -1 B
/discover-more/team ▼ -10 B (-0.15% ) 6.67 kB -- -1 B
/getting-started/templates/blog ▼ -10 B (-0.13% ) 7.44 kB -- -1 B
/getting-started/templates/dashboard ▼ -10 B (-0.11% ) 8.86 kB -- -1 B
/getting-started/templates/sign-in-side ▼ -10 B (-0.11% ) 9.29 kB -- -1 B
/getting-started/templates/sign-in ▼ -10 B (-0.10% ) 9.53 kB -- -1 B
/premium-themes/onepirate/forgot-password ▲ +10 B (+1.00% ) 1.01 kB -- -1 B
/premium-themes/onepirate/privacy ▼ -10 B (-0.23% ) 4.43 kB -- -1 B
/system/shadows ▼ -10 B (-0.26% ) 3.85 kB -- -1 B
/_app -- 37.2 kB -- -1 B
/api-docs/alert-title -- 1.4 kB -- -1 B
/api-docs/alert -- 2.4 kB -- -1 B
/api-docs/app-bar -- 1.94 kB -- -1 B
/api-docs/autocomplete -- 4.61 kB -- -1 B
/api-docs/avatar-group -- 1.51 kB -- -1 B
/api-docs/avatar -- 1.86 kB -- -1 B
/api-docs/backdrop -- 1.72 kB -- -1 B
/api-docs/badge -- 2.13 kB -- -1 B
/api-docs/bottom-navigation-action -- 1.81 kB -- -1 B
/api-docs/bottom-navigation -- 1.7 kB -- -1 B
/api-docs/breadcrumbs -- 1.84 kB -- -1 B
/api-docs/button-base -- 2.33 kB -- -1 B
/api-docs/button-group -- 2.23 kB -- -1 B
/api-docs/button -- 2.56 kB -- -1 B
/api-docs/card-action-area -- 1.58 kB -- -1 B
/api-docs/card-actions -- 1.47 kB -- -1 B
/api-docs/card-content -- 1.45 kB -- -1 B
/api-docs/card-header -- 1.78 kB -- -1 B
/api-docs/card-media -- 1.69 kB -- -1 B
/api-docs/card -- 1.5 kB -- -1 B
/api-docs/checkbox -- 2.3 kB -- -1 B
/api-docs/chip -- 2.46 kB -- -1 B
/api-docs/circular-progress -- 2.07 kB -- -1 B
/api-docs/click-away-listener -- 1.37 kB -- -1 B
/api-docs/collapse -- 2.13 kB -- -1 B
/api-docs/container -- 1.86 kB -- -1 B
/api-docs/css-baseline -- 1.4 kB -- -1 B
/api-docs/dialog-actions -- 1.47 kB -- -1 B
/api-docs/dialog-content-text -- 1.48 kB -- -1 B
/api-docs/dialog-content -- 1.45 kB -- -1 B
/api-docs/dialog-title -- 1.49 kB -- -1 B
/api-docs/dialog -- 2.73 kB -- -1 B
/api-docs/divider -- 1.81 kB -- -1 B
/api-docs/drawer -- 2.13 kB -- -1 B
/api-docs/expansion-panel-actions -- 1.49 kB -- -1 B
/api-docs/expansion-panel-details -- 1.41 kB -- -1 B
/api-docs/expansion-panel-summary -- 1.72 kB -- -1 B
/api-docs/expansion-panel -- 1.97 kB -- -1 B
/api-docs/fab -- 2.11 kB -- -1 B
/api-docs/fade -- 1.5 kB -- -1 B
/api-docs/filled-input -- 2.87 kB -- -1 B
/api-docs/form-control-label -- 1.98 kB -- -1 B
/api-docs/form-control -- 2.36 kB -- -1 B
/api-docs/form-group -- 1.55 kB -- -1 B
/api-docs/form-helper-text -- 1.91 kB -- -1 B
/api-docs/form-label -- 1.84 kB -- -1 B
/api-docs/grid -- 2.56 kB -- -1 B
/api-docs/grow -- 1.55 kB -- -1 B
/api-docs/hidden -- 1.53 kB -- -1 B
/api-docs/icon-button -- 2.1 kB -- -1 B
/api-docs/icon -- 1.78 kB -- -1 B
/api-docs/input-adornment -- 1.93 kB -- -1 B
/api-docs/input-base -- 2.95 kB -- -1 B
/api-docs/input-label -- 2.07 kB -- -1 B
/api-docs/input -- 2.83 kB -- -1 B
/api-docs/linear-progress -- 2.03 kB -- -1 B
/api-docs/link -- 1.93 kB -- -1 B
/api-docs/list-item-avatar -- 1.5 kB -- -1 B
/api-docs/list-item-icon -- 1.51 kB -- -1 B
/api-docs/list-item-secondary-action -- 1.47 kB -- -1 B
/api-docs/list-item-text -- 1.79 kB -- -1 B
/api-docs/list-item -- 2.25 kB -- -1 B
/api-docs/list-subheader -- 1.77 kB -- -1 B
/api-docs/list -- 1.68 kB -- -1 B
/api-docs/menu-item -- 1.74 kB -- -1 B
/api-docs/menu-list -- 1.57 kB -- -1 B
/api-docs/mobile-stepper -- 1.93 kB -- -1 B
/api-docs/modal -- 2.42 kB -- -1 B
/api-docs/native-select -- 2.08 kB -- -1 B
/api-docs/no-ssr -- 1.3 kB -- -1 B
/api-docs/outlined-input -- 2.98 kB -- -1 B
/api-docs/pagination-item -- 1.97 kB -- -1 B
/api-docs/pagination -- 2.24 kB -- -1 B
/api-docs/paper -- 1.87 kB -- -1 B
/api-docs/popover -- 2.69 kB -- -1 B
/api-docs/popper -- 1.91 kB -- -1 B
/api-docs/portal -- 1.34 kB -- -1 B
/api-docs/radio-group -- 1.45 kB -- -1 B
/api-docs/radio -- 2.12 kB -- -1 B
/api-docs/rating -- 2.49 kB -- -1 B
/api-docs/root-ref -- 1.41 kB -- -1 B
/api-docs/scoped-css-baseline -- 1.4 kB -- -1 B
/api-docs/select -- 2.94 kB -- -1 B
/api-docs/skeleton -- 1.77 kB -- -1 B
/api-docs/slide -- 1.54 kB -- -1 B
/api-docs/slider -- 3.11 kB -- -1 B
/api-docs/snackbar-content -- 1.61 kB -- -1 B
/api-docs/snackbar -- 2.71 kB -- -1 B
/api-docs/speed-dial-action -- 2.04 kB -- -1 B
/api-docs/speed-dial-icon -- 1.55 kB -- -1 B
/api-docs/speed-dial -- 2.3 kB -- -1 B
/api-docs/step-button -- 1.63 kB -- -1 B
/api-docs/step-connector -- 1.54 kB -- -1 B
/api-docs/step-content -- 1.72 kB -- -1 B
/api-docs/step-icon -- 1.57 kB -- -1 B
/api-docs/step-label -- 1.9 kB -- -1 B
/api-docs/step -- 1.64 kB -- -1 B
/api-docs/stepper -- 1.84 kB -- -1 B
/api-docs/svg-icon -- 2.26 kB -- -1 B
/api-docs/swipeable-drawer -- 2 kB -- -1 B
/api-docs/switch -- 2.46 kB -- -1 B
/api-docs/tab-context -- 1.05 kB -- -1 B
/api-docs/tab-list -- 1.08 kB -- -1 B
/api-docs/tab-panel -- 1.45 kB -- -1 B
/api-docs/tab-scroll-button -- 1.61 kB -- -1 B
/api-docs/tab -- 1.99 kB -- -1 B
/api-docs/table-body -- 1.47 kB -- -1 B
/api-docs/table-cell -- 2.13 kB -- -1 B
/api-docs/table-container -- 1.48 kB -- -1 B
/api-docs/table-footer -- 1.47 kB -- -1 B
/api-docs/table-head -- 1.46 kB -- -1 B
/api-docs/table-pagination -- 2.46 kB -- -1 B
/api-docs/table-row -- 1.69 kB -- -1 B
/api-docs/table-sort-label -- 1.83 kB -- -1 B
/api-docs/table -- 1.68 kB -- -1 B
/api-docs/tabs -- 2.68 kB -- -1 B
/api-docs/text-field -- 3.18 kB -- -1 B
/api-docs/textarea-autosize -- 1.13 kB -- -1 B
/api-docs/toggle-button-group -- 1.81 kB -- -1 B
/api-docs/toggle-button -- 1.8 kB -- -1 B
/api-docs/toolbar -- 1.65 kB -- -1 B
/api-docs/tooltip -- 2.54 kB -- -1 B
/api-docs/tree-item -- 1.88 kB -- -1 B
/api-docs/tree-view -- 1.92 kB -- -1 B
/api-docs/typography -- 2.59 kB -- -1 B
/api-docs/zoom -- 1.52 kB -- -1 B
/blog/2019-developer-survey-results -- 6.36 kB -- -1 B
/blog/2019 -- 4.24 kB -- -1 B
/blog/2020-introducing-sketch -- 3.5 kB -- -1 B
/blog/2020-q1-update -- 4.33 kB -- -1 B
/blog/april-2019-update -- 3.13 kB -- -1 B
/blog/august-2019-update -- 2.24 kB -- -1 B
/blog/december-2019-update -- 2.37 kB -- -1 B
/blog/july-2019-update -- 2.13 kB -- -1 B
/blog/june-2019-update -- 2.01 kB -- -1 B
/blog/march-2019-update -- 2.54 kB -- -1 B
/blog/material-ui-v1-is-out -- 6.67 kB -- -1 B
/blog/material-ui-v4-is-out -- 9.68 kB -- -1 B
/blog/may-2019-update -- 2.35 kB -- -1 B
/blog/november-2019-update -- 2.75 kB -- -1 B
/blog/september-2019-update -- 2.68 kB -- -1 B
/company/about -- 1.74 kB -- -1 B
/company/contact -- 1.33 kB -- -1 B
/company/jobs -- 1.35 kB -- -1 B
/components/about-the-lab -- 6.8 kB -- -1 B
/components/alert -- 12.9 kB -- -1 B
/components/app-bar -- 30.2 kB -- -1 B
/components/autocomplete -- 100 kB -- -1 B
/components/avatars -- 9.16 kB -- -1 B
/components/backdrop -- 2.68 kB -- -1 B
/components/badges -- 15.5 kB -- -1 B
/components/bottom-navigation -- 6.27 kB -- -1 B
/components/box -- 8.05 kB -- -1 B
/components/breadcrumbs -- 14.7 kB -- -1 B
/components/button-group -- 7.43 kB -- -1 B
/components/buttons -- 26.2 kB -- -1 B
/components/cards -- 17.3 kB -- -1 B
/components/checkboxes -- 16.3 kB -- -1 B
/components/chips -- 21.8 kB -- -1 B
/components/click-away-listener -- 4.58 kB -- -1 B
/components/container -- 3.72 kB -- -1 B
/components/css-baseline -- 6.74 kB -- -1 B
/components/dialogs -- 42.8 kB -- -1 B
/components/dividers -- 12.8 kB -- -1 B
/components/drawers -- 31.5 kB -- -1 B
/components/expansion-panels -- 20.7 kB -- -1 B
/components/floating-action-button -- 10.6 kB -- -1 B
/components/grid-list -- 12.1 kB -- -1 B
/components/grid -- 32.4 kB -- -1 B
/components/hidden -- 10.6 kB -- -1 B
/components/icons -- 27.3 kB -- -1 B
/components/links -- 6.91 kB -- -1 B
/components/lists -- 26.7 kB -- -1 B
/components/material-icons -- 729 kB -- -1 B
/components/menus -- 24.9 kB -- -1 B
/components/modal -- 11.9 kB -- -1 B
/components/no-ssr -- 5.11 kB -- -1 B
/components/pagination -- 9.45 kB -- -1 B
/components/paper -- 3.49 kB -- -1 B
/components/popover -- 17.4 kB -- -1 B
/components/popper -- 23.4 kB -- -1 B
/components/portal -- 3 kB -- -1 B
/components/progress -- 20.3 kB -- -1 B
/components/radio-buttons -- 14.8 kB -- -1 B
/components/rating -- 10.8 kB -- -1 B
/components/selects -- 31.2 kB -- -1 B
/components/slider -- 15.6 kB -- -1 B
/components/snackbars -- 27.8 kB -- -1 B
/components/speed-dial -- 14.6 kB -- -1 B
/components/steppers -- 36.6 kB -- -1 B
/components/switches -- 16.4 kB -- -1 B
/components/tables -- 143 kB -- -1 B
/components/tabs -- 23.3 kB -- -1 B
/components/text-fields -- 54.8 kB -- -1 B
/components/textarea-autosize -- 2.94 kB -- -1 B
/components/toggle-button -- 10.5 kB -- -1 B
/components/tooltips -- 17 kB -- -1 B
/components/transfer-list -- 9.68 kB -- -1 B
/components/transitions -- 12.1 kB -- -1 B
/components/tree-view -- 11.2 kB -- -1 B
/components/typography -- 9.92 kB -- -1 B
/components/use-media-query -- 12.9 kB -- -1 B
/customization/breakpoints -- 16 kB -- -1 B
/customization/color -- 20.9 kB -- -1 B
/customization/components -- 38.4 kB -- -1 B
/customization/default-theme -- 8.8 kB -- -1 B
/customization/globals -- 4.72 kB -- -1 B
/customization/palette -- 14.1 kB -- -1 B
/customization/spacing -- 2.61 kB -- -1 B
/customization/theming -- 18.7 kB -- -1 B
/customization/typography -- 11.8 kB -- -1 B
/customization/z-index -- 3.13 kB -- -1 B
/discover-more/backers -- 3.05 kB -- -1 B
/discover-more/changelog -- 1.44 kB -- -1 B
/discover-more/languages -- 3.44 kB -- -1 B
/discover-more/related-projects -- 7.96 kB -- -1 B
/discover-more/roadmap -- 3.72 kB -- -1 B
/discover-more/showcase -- 13.4 kB -- -1 B
/discover-more/vision -- 6.68 kB -- -1 B
/getting-started/example-projects -- 6.94 kB -- -1 B
/getting-started/faq -- 36.2 kB -- -1 B
/getting-started/installation -- 7.83 kB -- -1 B
/getting-started/learn -- 8.98 kB -- -1 B
/getting-started/support -- 9.15 kB -- -1 B
/getting-started/supported-components -- 6.7 kB -- -1 B
/getting-started/supported-platforms -- 5.84 kB -- -1 B
/getting-started/templates -- 8.92 kB -- -1 B
/getting-started/templates/album -- 5.59 kB -- -1 B
/getting-started/templates/checkout -- 11.2 kB -- -1 B
/getting-started/templates/pricing -- 7.8 kB -- -1 B
/getting-started/templates/sign-up -- 9.64 kB -- -1 B
/getting-started/templates/sticky-footer -- 1.54 kB -- -1 B
/getting-started/usage -- 9.58 kB -- -1 B
/guides/api -- 15.8 kB -- -1 B
/guides/composition -- 14.9 kB -- -1 B
/guides/flow -- 2.26 kB -- -1 B
/guides/interoperability -- 16.3 kB -- -1 B
/guides/localization -- 11.8 kB -- -1 B
/guides/migration-v0x -- 7.39 kB -- -1 B
/guides/migration-v3 -- 19.2 kB -- -1 B
/guides/minimizing-bundle-size -- 8.7 kB -- -1 B
/guides/responsive-ui -- 4.27 kB -- -1 B
/guides/right-to-left -- 6.77 kB -- -1 B
/guides/server-rendering -- 8.75 kB -- -1 B
/guides/testing -- 8.61 kB -- -1 B
/guides/typescript -- 15.1 kB -- -1 B
/performance/table-component -- 1.44 kB -- -1 B
/performance/table-emotion -- 8.5 kB -- -1 B
/performance/table-hook -- 2.24 kB -- -1 B
/performance/table-mui -- 4.49 kB -- -1 B
/performance/table-raw -- 613 B -- -1 B
/performance/table-styled-components -- 2.6 kB -- -1 B
/premium-themes/onepirate -- 7.32 kB -- -1 B
/premium-themes/onepirate/sign-in -- 1.07 kB -- -1 B
/premium-themes/onepirate/sign-up -- 1.12 kB -- -1 B
/premium-themes/onepirate/terms -- 11.8 kB -- -1 B
/premium-themes/paperbase -- 8.96 kB -- -1 B
/styles/advanced -- 33.3 kB -- -1 B
/styles/api -- 16.9 kB -- -1 B
/styles/basics -- 16.5 kB -- -1 B
/system/api -- 5.96 kB -- -1 B
/system/basics -- 27.4 kB -- -1 B
/system/borders -- 4.1 kB -- -1 B
/system/display -- 6.55 kB -- -1 B
/system/flexbox -- 5.85 kB -- -1 B
/system/palette -- 4.35 kB -- -1 B
/system/positions -- 2.53 kB -- -1 B
/system/sizing -- 3.53 kB -- -1 B
/system/spacing -- 6.01 kB -- -1 B
/system/typography -- 4.41 kB -- -1 B
/versions -- 23.7 kB -- -1 B
docs:chunk:shared -- 61.7 kB -- -1 B
docs:shared:chunk/commons -- 5.99 kB -- -1 B
docs:shared:chunk/framework -- 42.3 kB -- -1 B
docs:shared:runtime/main -- 6.78 kB -- -1 B
docs:shared:runtime/webpack -- 1.24 kB -- -1 B
bundle Size Change Size Gzip Change Gzip
@material-ui/core[umd] ▲ +25 B (+0.01% ) 326 kB ▲ +9 B (+0.01% ) 95 kB
FormHelperText ▲ +25 B (+0.04% ) 68.3 kB ▲ +8 B (+0.04% ) 21.3 kB
@material-ui/styles ▲ +25 B (+0.05% ) 52.1 kB ▲ +7 B (+0.04% ) 15.6 kB
Slider ▲ +25 B (+0.03% ) 80.9 kB ▲ +7 B (+0.03% ) 25.9 kB
TextField ▲ +25 B (+0.02% ) 131 kB ▲ +7 B (+0.02% ) 38.5 kB
CardActionArea ▲ +25 B (+0.03% ) 79.6 kB ▲ +6 B (+0.02% ) 25.2 kB
CardContent ▲ +25 B (+0.04% ) 66.9 kB ▲ +6 B (+0.03% ) 21 kB
Divider ▲ +25 B (+0.04% ) 67.6 kB ▲ +6 B (+0.03% ) 21.3 kB
SpeedDial ▲ +25 B (+0.03% ) 91.6 kB ▲ +6 B (+0.02% ) 29.2 kB
SpeedDialAction ▲ +25 B (+0.02% ) 123 kB ▲ +6 B (+0.02% ) 39.3 kB
BottomNavigationAction ▲ +25 B (+0.03% ) 80 kB ▲ +5 B (+0.02% ) 25.5 kB
Grid ▲ +25 B (+0.04% ) 70 kB ▲ +5 B (+0.02% ) 22 kB
Hidden ▲ +25 B (+0.04% ) 70.9 kB ▲ +5 B (+0.02% ) 22.3 kB
MenuList ▲ +25 B (+0.04% ) 71 kB ▲ +5 B (+0.02% ) 22.2 kB
MobileStepper ▲ +25 B (+0.03% ) 72.8 kB ▲ +5 B (+0.02% ) 22.9 kB
Skeleton ▲ +25 B (+0.04% ) 67.9 kB ▲ +5 B (+0.02% ) 21.5 kB
TableSortLabel ▲ +25 B (+0.03% ) 81.9 kB ▲ +5 B (+0.02% ) 26.1 kB
@material-ui/core ▲ +25 B (+0.01% ) 371 kB ▲ +4 B (0.00% ) 102 kB
Badge ▲ +25 B (+0.04% ) 70.2 kB ▲ +4 B (+0.02% ) 21.9 kB
Box ▲ +25 B (+0.03% ) 73.8 kB ▲ +4 B (+0.02% ) 22.4 kB
Breadcrumbs ▲ +25 B (+0.03% ) 85 kB ▲ +4 B (+0.01% ) 27 kB
Button ▲ +25 B (+0.03% ) 84.3 kB ▲ +4 B (+0.02% ) 25.9 kB
ButtonGroup ▲ +25 B (+0.03% ) 87.9 kB ▲ +4 B (+0.01% ) 27.2 kB
Card ▲ +25 B (+0.04% ) 67.8 kB ▲ +4 B (+0.02% ) 21.3 kB
ExpansionPanelSummary ▲ +25 B (+0.03% ) 82.7 kB ▲ +4 B (+0.02% ) 26.2 kB
ListItemAvatar ▲ +25 B (+0.04% ) 67 kB ▲ +4 B (+0.02% ) 21 kB
ListSubheader ▲ +25 B (+0.04% ) 67.7 kB ▲ +4 B (+0.02% ) 21.3 kB
OutlinedInput ▲ +25 B (+0.03% ) 79.7 kB ▲ +4 B (+0.02% ) 24.9 kB
Switch ▲ +25 B (+0.03% ) 85.9 kB ▲ +4 B (+0.01% ) 27 kB
Tab ▲ +25 B (+0.03% ) 81 kB ▲ +4 B (+0.02% ) 25.8 kB
TablePagination ▲ +25 B (+0.02% ) 148 kB ▲ +4 B (+0.01% ) 43.8 kB
ToggleButton ▲ +25 B (+0.03% ) 80.6 kB ▲ +4 B (+0.02% ) 25.6 kB
Typography ▲ +25 B (+0.04% ) 68.5 kB ▲ +4 B (+0.02% ) 21.4 kB
@material-ui/lab ▲ +25 B (+0.01% ) 217 kB ▲ +3 B (0.00% ) 64.7 kB
AlertTitle ▲ +25 B (+0.04% ) 69.1 kB ▲ +3 B (+0.01% ) 21.8 kB
AppBar ▲ +25 B (+0.04% ) 68.9 kB ▲ +3 B (+0.01% ) 21.7 kB
Autocomplete ▲ +25 B (+0.02% ) 136 kB ▲ +3 B (+0.01% ) 42.9 kB
Avatar ▲ +25 B (+0.04% ) 70.1 kB ▲ +3 B (+0.01% ) 22 kB
BottomNavigation ▲ +25 B (+0.04% ) 67.3 kB ▲ +3 B (+0.01% ) 21.1 kB
ButtonBase ▲ +25 B (+0.03% ) 78.5 kB ▲ +3 B (+0.01% ) 24.7 kB
CardActions ▲ +25 B (+0.04% ) 67 kB ▲ +3 B (+0.01% ) 21 kB
CardHeader ▲ +25 B (+0.04% ) 70 kB ▲ +3 B (+0.01% ) 22.1 kB
CardMedia ▲ +25 B (+0.04% ) 67.3 kB ▲ +3 B (+0.01% ) 21.2 kB
Checkbox ▲ +25 B (+0.03% ) 86.7 kB ▲ +3 B (+0.01% ) 27.4 kB
CircularProgress ▲ +25 B (+0.04% ) 69 kB ▲ +3 B (+0.01% ) 21.8 kB
Container ▲ +25 B (+0.04% ) 68.1 kB ▲ +3 B (+0.01% ) 21.3 kB
CssBaseline ▲ +25 B (+0.04% ) 66.9 kB ▲ +3 B (+0.01% ) 21.1 kB
DialogActions ▲ +25 B (+0.04% ) 67 kB ▲ +3 B (+0.01% ) 21.1 kB
DialogContentText ▲ +25 B (+0.04% ) 69 kB ▲ +3 B (+0.01% ) 21.7 kB
DialogTitle ▲ +25 B (+0.04% ) 69.2 kB ▲ +3 B (+0.01% ) 21.8 kB
ExpansionPanelDetails ▲ +25 B (+0.04% ) 66.9 kB ▲ +3 B (+0.01% ) 21 kB
FormControlLabel ▲ +25 B (+0.04% ) 70.4 kB ▲ +3 B (+0.01% ) 22.2 kB
FormGroup ▲ +25 B (+0.04% ) 66.9 kB ▲ +3 B (+0.01% ) 21 kB
GridList ▲ +25 B (+0.04% ) 67.4 kB ▲ +3 B (+0.01% ) 21.2 kB
GridListTileBar ▲ +25 B (+0.04% ) 68.1 kB ▲ +3 B (+0.01% ) 21.4 kB
InputAdornment ▲ +25 B (+0.04% ) 70 kB ▲ +3 B (+0.01% ) 22.1 kB
Link ▲ +25 B (+0.03% ) 71.5 kB ▲ +3 B (+0.01% ) 22.7 kB
ListItem ▲ +25 B (+0.03% ) 81.6 kB ▲ +3 B (+0.01% ) 25.6 kB
ListItemText ▲ +25 B (+0.04% ) 69.9 kB ▲ +3 B (+0.01% ) 22 kB
MenuItem ▲ +25 B (+0.03% ) 82.7 kB ▲ +3 B (+0.01% ) 26 kB
NativeSelect ▲ +25 B (+0.03% ) 82 kB ▲ +3 B (+0.01% ) 25.9 kB
Pagination ▲ +25 B (+0.03% ) 89 kB ▲ +3 B (+0.01% ) 27.5 kB
Paper ▲ +25 B (+0.04% ) 67.3 kB ▲ +3 B (+0.01% ) 21 kB
Radio ▲ +25 B (+0.03% ) 87.7 kB ▲ +3 B (+0.01% ) 27.8 kB
Rating ▲ +25 B (+0.03% ) 75.8 kB ▲ +3 B (+0.01% ) 24.4 kB
ScopedCssBaseline ▲ +25 B (+0.04% ) 67.8 kB ▲ +3 B (+0.01% ) 21.3 kB
SnackbarContent ▲ +25 B (+0.04% ) 68.5 kB ▲ +3 B (+0.01% ) 21.6 kB
SpeedDialIcon ▲ +25 B (+0.04% ) 69.5 kB ▲ +3 B (+0.01% ) 21.9 kB
StepButton ▲ +25 B (+0.03% ) 86.8 kB ▲ +3 B (+0.01% ) 27.5 kB
StepConnector ▲ +25 B (+0.04% ) 67.6 kB ▲ +3 B (+0.01% ) 21.3 kB
StepLabel ▲ +25 B (+0.03% ) 73.5 kB ▲ +3 B (+0.01% ) 22.8 kB
Stepper ▲ +25 B (+0.04% ) 69.8 kB ▲ +3 B (+0.01% ) 22 kB
Table ▲ +25 B (+0.04% ) 67.5 kB ▲ +3 B (+0.01% ) 21.2 kB
TableCell ▲ +25 B (+0.04% ) 69 kB ▲ +3 B (+0.01% ) 21.8 kB
TableContainer ▲ +25 B (+0.04% ) 66.9 kB ▲ +3 B (+0.01% ) 21 kB
TableFooter ▲ +25 B (+0.04% ) 67.1 kB ▲ +3 B (+0.01% ) 21 kB
TableHead ▲ +25 B (+0.04% ) 67.1 kB ▲ +3 B (+0.01% ) 21 kB
TableRow ▲ +25 B (+0.04% ) 67.4 kB ▲ +3 B (+0.01% ) 21.2 kB
TabList ▲ +25 B (+0.03% ) 91.9 kB ▲ +3 B (+0.01% ) 29.4 kB
TabPanel ▲ +25 B (+0.04% ) 70 kB ▲ +3 B (+0.01% ) 22 kB
Tabs ▲ +25 B (+0.03% ) 90.6 kB ▲ +3 B (+0.01% ) 28.4 kB
ToggleButtonGroup ▲ +25 B (+0.04% ) 67.7 kB ▲ +3 B (+0.01% ) 21.3 kB
TreeItem ▲ +25 B (+0.03% ) 80.9 kB ▲ +3 B (+0.01% ) 25.8 kB
TreeView ▲ +25 B (+0.03% ) 73.3 kB ▲ +3 B (+0.01% ) 23.1 kB
Alert ▲ +25 B (+0.03% ) 87.8 kB ▲ +2 B (+0.01% ) 27.8 kB
AvatarGroup ▲ +25 B (+0.04% ) 71.1 kB ▲ +2 B (+0.01% ) 22.6 kB
Chip ▲ +25 B (+0.03% ) 87.2 kB ▲ +2 B (+0.01% ) 26.8 kB
Collapse ▲ +25 B (+0.03% ) 74 kB ▲ +2 B (+0.01% ) 22.9 kB
Dialog ▲ +25 B (+0.03% ) 88.8 kB ▲ +2 B (+0.01% ) 27.9 kB
DialogContent ▲ +25 B (+0.04% ) 67.1 kB ▲ +2 B (+0.01% ) 21.1 kB
ExpansionPanel ▲ +25 B (+0.03% ) 77.6 kB ▲ +2 B (+0.01% ) 24.5 kB
ExpansionPanelActions ▲ +25 B (+0.04% ) 67 kB ▲ +2 B (+0.01% ) 21 kB
Fab ▲ +25 B (+0.03% ) 81.3 kB ▲ +2 B (+0.01% ) 25.4 kB
FilledInput ▲ +25 B (+0.03% ) 78.7 kB ▲ +2 B (+0.01% ) 24.5 kB
FormControl ▲ +25 B (+0.04% ) 69.3 kB ▲ +2 B (+0.01% ) 21.6 kB
FormLabel ▲ +25 B (+0.04% ) 68.4 kB ▲ +2 B (+0.01% ) 21.2 kB
GridListTile ▲ +25 B (+0.04% ) 68.6 kB ▲ +2 B (+0.01% ) 21.6 kB
Icon ▲ +25 B (+0.04% ) 67.7 kB ▲ +2 B (+0.01% ) 21.2 kB
IconButton ▲ +25 B (+0.03% ) 80.7 kB ▲ +2 B (+0.01% ) 25.3 kB
Input ▲ +25 B (+0.03% ) 77.6 kB ▲ +2 B (+0.01% ) 24.3 kB
InputBase ▲ +25 B (+0.03% ) 75.7 kB ▲ +2 B (+0.01% ) 23.8 kB
InputLabel ▲ +25 B (+0.04% ) 70.2 kB ▲ +2 B (+0.01% ) 21.7 kB
LinearProgress ▲ +25 B (+0.04% ) 70.3 kB ▲ +2 B (+0.01% ) 21.8 kB
List ▲ +25 B (+0.04% ) 67.2 kB ▲ +2 B (+0.01% ) 21 kB
ListItemSecondaryAction ▲ +25 B (+0.04% ) 66.9 kB ▲ +2 B (+0.01% ) 21 kB
PaginationItem ▲ +25 B (+0.03% ) 85.4 kB ▲ +2 B (+0.01% ) 26.4 kB
RadioGroup ▲ +25 B (+0.04% ) 68.8 kB ▲ +2 B (+0.01% ) 21.4 kB
Snackbar ▲ +25 B (+0.03% ) 81.6 kB ▲ +2 B (+0.01% ) 25.7 kB
Step ▲ +25 B (+0.04% ) 67.6 kB ▲ +2 B (+0.01% ) 21.2 kB
StepContent ▲ +25 B (+0.03% ) 75.1 kB ▲ +2 B (+0.01% ) 23.6 kB
StepIcon ▲ +25 B (+0.04% ) 69.5 kB ▲ +2 B (+0.01% ) 21.7 kB
SvgIcon ▲ +25 B (+0.04% ) 67.9 kB ▲ +2 B (+0.01% ) 21.2 kB
Tooltip ▲ +25 B (+0.02% ) 108 kB ▲ +2 B (+0.01% ) 34 kB
Backdrop ▲ +25 B (+0.03% ) 73.6 kB ▲ +1 B (0.00% ) 22.8 kB
ListItemIcon ▲ +25 B (+0.04% ) 67.1 kB ▲ +1 B (0.00% ) 21.1 kB
Popover ▲ +25 B (+0.03% ) 88.8 kB ▲ +1 B (0.00% ) 27.5 kB
Select ▲ +25 B (+0.02% ) 122 kB ▼ -1 B (-0.00% ) 36.4 kB
SwipeableDrawer ▲ +25 B (+0.03% ) 98.3 kB ▲ +1 B (0.00% ) 30.9 kB
TableBody ▲ +25 B (+0.04% ) 67.1 kB ▲ +1 B (0.00% ) 21 kB
TabScrollButton ▲ +25 B (+0.03% ) 81.5 kB ▲ +1 B (0.00% ) 25.6 kB
Toolbar ▲ +25 B (+0.04% ) 67.2 kB ▲ +1 B (0.00% ) 21.2 kB
Drawer ▲ +25 B (+0.03% ) 90.8 kB -- 27.7 kB
Menu ▲ +25 B (+0.03% ) 94.4 kB -- 29.2 kB
@material-ui/system -- 17.2 kB -- 4.52 kB
ClickAwayListener -- 4.13 kB -- 1.65 kB
colorManipulator -- 3.96 kB -- 1.55 kB
docs:/ -- 12.1 kB -- -1 B
docs:/_app -- 37.2 kB -- -1 B
Fade -- 29.4 kB -- 9.84 kB
Grow -- 30 kB -- 10.1 kB
Modal -- 15 kB -- 5.25 kB
NoSsr -- 2.18 kB -- 1.03 kB
Popper -- 28.8 kB -- 10.3 kB
Portal -- 2.87 kB -- 1.29 kB
RootRef -- 4.64 kB -- 1.76 kB
Slide -- 31.1 kB -- 10.3 kB
styles/createMuiTheme -- 22.4 kB -- 7.75 kB
TabContext -- 2.65 kB -- 1.15 kB
TextareaAutosize -- 5.24 kB -- 2.19 kB
useAutocomplete -- 14.5 kB -- 5.18 kB
useMediaQuery -- 2.57 kB -- 1.06 kB
useScrollTrigger -- 2.66 kB -- 1.08 kB
Zoom -- 29.4 kB -- 9.97 kB

Generated by 🚫 dangerJS against 3e5e1fa

@oliviertassinari oliviertassinari changed the title [Styles]: Increase counter only for non global styles [styles]Increase counter only for non global styles May 12, 2020
@oliviertassinari oliviertassinari changed the title [styles]Increase counter only for non global styles [styles] Increase counter only for non global styles May 12, 2020
@oliviertassinari
Copy link
Member

@jantimon No specific objection to going in this direction. However, what problem do you plan to solve? How are the change valuable?

@jantimon
Copy link
Contributor Author

I was just confused why it would increase the numbers "randomly".

But you are right the value would be rather low:

  • it would be slightly easier to see how many non deterministic classes have been generated
  • the server side rendered css class names might be 1 or 2 digits shorter.

@oliviertassinari
Copy link
Member

oliviertassinari commented May 13, 2020 •
edited

@jantimon Ok sounds fair. Do you want to fix the CI so we can move the pull request forward? Thanks

@jantimon
Copy link
Contributor Author

jantimon commented May 13, 2020 •
edited

Okay it works 🎉

While looking through the code I saw something strange:

Mui- styles with a selectorCounter will not be minified for production - is that intended?

Removing line 62 in this file could fix that:

https://github.com/mui-org/material-ui/blob/e25b7d54f0f0eda6abdd50acb489d6e861cb89ce/packages/material-ui-styles/src/createGenerateClassName/createGenerateClassName.js#L49-L67

There are also no tests for that scenario (production + seed)

@oliviertassinari oliviertassinari added the package: styles Specific to @mui/styles. Legacy package, @material-ui/styled-engine is taking over in v5. label May 14, 2020
@oliviertassinari oliviertassinari merged commit 5bc7411 into mui:master May 14, 2020
@oliviertassinari
Copy link
Member

oliviertassinari commented May 14, 2020 •
edited

@jantimon Thanks for the patch.

While looking through the code I saw something strange:

I think that the incentive was to help developers debug the style of the application in production. It can be perceived as inconsistent with when the style doesn't come from Material-UI components. At least, the Material-UI components garentuee the unique of the style sheet names

@jantimon
Copy link
Contributor Author

I guess that’s a good point.
Thanks for clarification 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
package: styles Specific to @mui/styles. Legacy package, @material-ui/styled-engine is taking over in v5.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jantimon @mui-pr-bot @oliviertassinari