-
-
Notifications
You must be signed in to change notification settings - Fork 31.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CircularProgress] Improve custom bar demo #21005
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since this component has to display background behind a "real" progress, the `100` value has to be overridden, otherwise it won't be displayed since their values are the same.
Details of bundle changes.Comparing: a8902de...0045854 Details of page changes
|
id0Sch
changed the title
[docs]: fix custom progress bar example
[docs] fix custom progress bar example
May 12, 2020
oliviertassinari
added
component: CircularProgress
The React component
docs
Improvements or additions to the documentation
labels
May 12, 2020
oliviertassinari
changed the title
[docs] fix custom progress bar example
[docs] Improve custom progress bar demo
May 12, 2020
@id0Sch It's a great first pull request on Material-UI 👌🏻. Thank you for working on it! |
@oliviertassinari thanks! |
oliviertassinari
changed the title
[docs] Improve custom progress bar demo
[CircularProgress] Improve custom bar demo
May 23, 2020
oliviertassinari
added
the
component: progress
This is the name of the generic UI component, not the React module!
label
Nov 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component: CircularProgress
The React component
component: progress
This is the name of the generic UI component, not the React module!
docs
Improvements or additions to the documentation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since this component has to display background behind a "real" progress, the
100
value has to be overridden, otherwise it won't be displayed since their values are the same.before:
after: