[docs] Recommend no-restricted-imports to catch treeshake issues #21035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eps1lon
added
docs
eps1lon
commented
May 14, 2020
docs/src/pages/customization/typography/ResponsiveFontSizesChart.js
Outdated
Show resolved
Hide resolved
Details of bundle changes.Comparing: 0cd1413...66017aa Details of page changes
|
oliviertassinari
approved these changes
May 14, 2020
There was a problem hiding this comment.
cc @dmtrKovalenko it seems that copying it isn't required (https://github.com/mui-org/material-ui-pickers/issues/1657#issuecomment-613474960).
docs/src/pages/customization/typography/ResponsiveFontSizesChart.js
Outdated
Show resolved
Hide resolved
|
@eps1lon The plugin isn't published on npm, should we replace all the labels with "core"? |
Let's deprecate https://www.npmjs.com/package/eslint-plugin-material-ui then. |
eps1lon
removed
breaking change
package: eslint
eps1lon
changed the title
joshwooding
reviewed
May 15, 2020
docs/src/pages/guides/minimizing-bundle-size/minimizing-bundle-size.md
Outdated
Show resolved
Hide resolved
…-size.md Co-authored-by: Josh Wooding <12938082+joshwooding@users.noreply.github.com>
Sure. At least, for now, there is no more good reason to install the package. I don't have write access so I can't do it. Arguably, there is very few downloads, "last published 4 years ago" feels like quite deprecated 🙃. |
Yet, we have requests to publish the latest versions. |
I believe this pull request addresses the request 👌, the incentive was to benefit from the restricted import path. |
joshwooding
approved these changes
May 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drop custom rule in favor of the built-in
no-restricted-importsrule.