-
-
Notifications
You must be signed in to change notification settings - Fork 31.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ToggleButton] Add orientation prop #21051
Merged
oliviertassinari
merged 2 commits into
mui:master
from
manishco:toggle-button-group-add-vertical-support
May 16, 2020
Merged
[ToggleButton] Add orientation prop #21051
oliviertassinari
merged 2 commits into
mui:master
from
manishco:toggle-button-group-add-vertical-support
May 16, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manishco
force-pushed
the
toggle-button-group-add-vertical-support
branch
from
May 15, 2020 23:56
efcdd08
to
0e53603
Compare
@material-ui/lab: parsed: +0.18% , gzip: +0.15% Details of bundle changes.Comparing: 758a8ad...8dc4446 Details of page changes
|
oliviertassinari
added
the
component: toggle button
This is the name of the generic UI component, not the React module!
label
May 16, 2020
oliviertassinari
changed the title
[ToggleButtonGroup] add orientation prop
[ToggleButtonGroup] Add orientation prop
May 16, 2020
oliviertassinari
force-pushed
the
toggle-button-group-add-vertical-support
branch
from
May 16, 2020 11:00
6c7afe8
to
8dc4446
Compare
oliviertassinari
approved these changes
May 16, 2020
@xiaomaini It's a great first pull request on Material-UI 👌🏻. Thank you for working on it! |
oliviertassinari
changed the title
[ToggleButtonGroup] Add orientation prop
[ToggleButton] Add orientation prop
May 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component: toggle button
This is the name of the generic UI component, not the React module!
new feature
New feature or request
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #21025