-
-
Notifications
You must be signed in to change notification settings - Fork 31.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Add new twitter quotes to the homepage #21061
Conversation
mbrookes
commented
May 16, 2020
- I have followed (at least) the PR section of the contributing guide.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that the next stage for the twitter quotes would be to collect the ones from "influencers" of the React community. Going up in the perceived value rather than growing the list in quantity :).
Details of bundle changes.Comparing: 15854b9...bde94b7 Details of page changes
|
When one of them quotes - we'll use it! For now, quantity adds variety. We could consider adding prev / next buttons to allow more to be viewed without reloading, but not sure it's worth the trouble. |
@mbrookes Any limit on the length of the list? |
Are you asking about showing more than 3 tweets? |
I was wondering about the max number of tweets we should use to "round-robin" on them, we have 9. I think that you are right, displaying 3 at the time might be enough, not sure a prev/next button is worth the effort. |