-
-
Notifications
You must be signed in to change notification settings - Fork 31.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Pagination] Document difference with TablePagination #21107
[Pagination] Document difference with TablePagination #21107
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great start. Could you add a version of the new demo in TypeScript too? Thanks!
Details of bundle changes.Comparing: 8357c68...4bbe1df Details of page changes
|
Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>
Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>
Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>
Sure thing! |
Co-authored-by: Josh Wooding <12938082+joshwooding@users.noreply.github.com>
…al-ui into update-table-pagination-md
Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>
@oliviertassinari @joshwooding Looks like there is a namespace conflict with the above change :( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have renamed the demo to solve the conflict. I'm not sure we have a better option here.
Agree! Thanks for looking into this. |
@hoop71 Thanks :) |
This PR address the additional documentation as discusses/ described in #19641.
Closes #19641