[docs] Replace typefaces with fontsource #21153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Details of bundle changes.Comparing: 90ae1b6...6cf46bf Details of page changes
|
oliviertassinari
approved these changes
May 23, 2020
oliviertassinari
changed the title
|
Let's wait to see where gatsbyjs/gatsby#24385 land before merging. |
|
I'm going ahead, 9 days and no answer from the Gatsby's team. I appreciate that your project allows to only include the necessary font weights, much better :). |
|
Hey @oliviertassinari , we took note of this PR from when it was sent and created an internal ticket to review it. Also note that there are a lot of PRs coming in daily so it might take a minute but we are on it 🙂. |
|
@Ekwuno :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced the ageing Typefaces project with a link to Fontsource, a newly actively maintained Open Source NPM font packager. Link : https://github.com/DecliningLotus/fontsource
The Typefaces project has somewhat been neglected over the years and has a long list of issues and pull requests that have left it outdated. Although very understandable, as I can imagine Kyle is very busy developing for Gatsby.
Fontsource is a major rebuild of this project, with added features such as the ability to choose subsets, weights and styles. It also clears up all the bugs from the previous project, checks for updates on Google Fonts on a weekly basis via Github Actions, has far more in-depth documentation and is also adding a lot more Open Source fonts that haven't been added by the original Typefaces project.
Let me know if there are any concerns and thoughts toward this!