-
-
Notifications
You must be signed in to change notification settings - Fork 31.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adapt CONTRIBUTING.md for https instead of SSH git clone #21187
Adapt CONTRIBUTING.md for https instead of SSH git clone #21187
Conversation
If no ssh key is activated, old links in CONTRIBUTING.md without https generates error on git pull upstream master
An upstream for new branch needs to be created to be able to push it.
Details of bundle changes.Comparing: ca56365...522e8da Details of page changes
|
Personally, I would be in favor of sticking to SSH, per the approach we already recommend to new developers in https://egghead.io/lessons/javascript-how-to-authenticate-with-github-using-ssh. If somebody already has experience with GitHub, he will figure it out. What do you guys think? |
Not sure what you mean by "we already recommend in [video]" - that's just some random video by some random developer*, nothing to do with us. And it doesn't recommend it, just shows how to set it up. I agree with @cjoecker - a username and password is the lowest common denominator. If you use SSH, then you already have your key set up and know what URL to use; if you don't, it's one more barrier to contributing. *In the greater scheme of things. 😄 |
@mbrookes What I mean, is that in the same contribution guide, in the beginning, we encourage people to get started by following this course: https://egghead.io/courses/how-to-contribute-to-an-open-source-project-on-github
|
Actually, I think that I took the wrong angle. This part of the contribution guide is not targeted at new contributors to Open Source, but of Material-UI. |
|
@cjoecker It's a great first pull request on Material-UI 👌🏻. Thank you for working on it! |
I followed the instructions on CONTRIBUTING.md but got stuck because I don't have an SSH key. Therefore I adapted the instructions, so it can be followed for people with and without SSH key.