[docs] Add Progress value label examples #21190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
May 24, 2020 15:59
When arrow function is inside of component, no animation whas happening
Rounded value was moved to first component in example so that it is consistent with circular progress
Details of bundle changes.Comparing: 29e68da...0b3bc51 Details of page changes
|
mbrookes
changed the title
eps1lon
requested changes
May 25, 2020
eps1lon
force-pushed
the
add-progress-value-label
branch
from
02f1ec1
to
685329b
Compare
|
@eps1lon do you know why |
The failed step should give you a good hint:
|
oliviertassinari
added
component: CircularProgress
cjoecker
commented
May 25, 2020
oliviertassinari
force-pushed
the
add-progress-value-label
branch
from
532c78c
to
50a8f0c
Compare
|
@cjoecker Oops, I have messed-up my git, sorry. The curse of jumping between the pickers and core repositories (I'm not yet used to the master vs next branch difference). I'm gonna try to restore the change I was originally planning. |
|
@cjoecker Alright, I have pushed what I intended in the first place. We would love to get your feedback on the change. If you need anything that is strange or could be improved. |
cjoecker
commented
May 25, 2020
There was a problem hiding this comment.
Looks very good to me!
I would name the component CircularProgressWithLabel instead of CircularProgressLabel as the component is not a label. It is a circular progress with label. The same for LinearProgressLabel.
Shouldn't <Box minWidth={35}> be done with theme.spacing(x)?
I would write ### Linear with Label instead of ### Linear with label as the other titles have all capital letters. The same for circular progress.
|
oliviertassinari
approved these changes
May 25, 2020
github-actions
bot
added
PR: out-of-date
oliviertassinari
removed
the
PR: out-of-date
|
@cjoecker Thanks! |
oliviertassinari
added
the
component: progress
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #18322
For me is not clear from the contribution documentation, if automated tests for examples in the documentation are necessary.
This sentence makes me think that we should write tests for new examples but I didn't found any: