[TrapFocus] Make an unstable version public #21201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Details of bundle changes.Comparing: f62b4b4...e008e93 Details of page changes
|
There was a problem hiding this comment.
I think that we would need to move the component to its own folder so it can be imported directly like any other
import Unstable_TrapFocus from '@material-ui/core/Unstable_TrapFocus';This should, in turn, enable API generation, TypeScript to prop-types generation, etc.
oliviertassinari
changed the title
dmtrKovalenko
commented
May 26, 2020
|
Everything works except multiline comment, that for some reason getting more spaces on each run of |
oliviertassinari
approved these changes
May 26, 2020
There was a problem hiding this comment.
Awesome, it's a good step forward for https://trello.com/c/SRvmJzrZ/1342-make-focustrap-public.
|
FYI, this change seems to have broken the latest three alpha builds (5-7) of I had the same experience as this issue in the pickers repo. Oh, the dangers of running with alpha! |
niculistana
added a commit
to ideo/shape
that referenced
this pull request
Jun 2, 2020
- fix Material UI TrapFocus issue, see: mui/material-ui#21201
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
<TrapFocus />needs for pickers migration toPopper. This PR makes it public and adds typescript defintions.