[docs] Track pixel ratio #21209
Merged
[docs] Track pixel ratio #21209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eps1lon
commented
May 26, 2020
| * Adjusted to track 3 or more different ratios | ||
| */ | ||
| function trackDevicePixelRation() { | ||
| window.ga('set', 'dimension3', window.devicePixelRatio); |
There was a problem hiding this comment.
Already added to google-analytics.
There was a problem hiding this comment.
I'm curious to see if we will get a long tail of values with decimals. Say, 2.33, 2.19, etc.
There was a problem hiding this comment.
It seems that we need to round the number. Are you able to process the information in this GA view?
Details of bundle changes.Comparing: a2e0e32...ebea1b8 Details of page changes
|
oliviertassinari
approved these changes
May 26, 2020
There was a problem hiding this comment.
It will be interesting to watch! I have been eager to add this in the past at two other companies (2016 & 2018) :)
I would guess between 40% and 33% of our audience has window.devicePixelRatio >= 2.
- All the new mac sold are high-density, mac is 37% of the audience for returning users.
- +80% of the designers have a high-density screen.
- +80% of the phones have a high-density screen.
| * Adjusted to track 3 or more different ratios | ||
| */ | ||
| function trackDevicePixelRation() { | ||
| window.ga('set', 'dimension3', window.devicePixelRatio); |
There was a problem hiding this comment.
I'm curious to see if we will get a long tail of values with decimals. Say, 2.33, 2.19, etc.
oliviertassinari
added a commit
to oliviertassinari/material-ui
that referenced
this pull request
May 30, 2020
This is an effort to reduce the concerns raised in mui#21209. We don't need to duplicate the information for the 1px web <-> 1px screen variant of the images.
oliviertassinari
added a commit
to oliviertassinari/material-ui
that referenced
this pull request
May 30, 2020
Google Analytics doesn't provide any tool to group close values. We have to group the value ourselves to reduce the cardinality of the possible values this dimension can take. After 24 hours, we had 185 different values mui#21209 (comment). After 4 days, we had 357 different values. My hope is that we will have most of the values (> 1%) on less than 40 possible values). This will make studying the result easier.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helps for decisions when we might want to add special hints for different screen ratios. If we have a big spread of ratios we should include them, otherwise not so much.
Also helpful if creating srcSets for 2x displays is useful.
Used the opportunity to refactor our
PersistStatewhich is really an "Analytics"-component.