[Table] Add React node support to TablePagination.labelRowsPerPage #21226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
added
the
component: table
1 task
Details of bundle changes.Comparing: d49be19...c091588 Details of page changes
|
eps1lon
added
PR: needs test
eps1lon
previously requested changes
May 27, 2020
oliviertassinari
changed the title
|
@eps1lon I couldn't make it work with the proposed solution. I have used testing-playground.com to find an alternative. |
| @@ -94,9 +96,13 @@ describe('<TablePagination />', () => { | |||
| </TableFooter> | |||
| </table>, | |||
| ); | |||
|
|
|||
| expect(getByRole('button', { name: 'Zeilen pro Seite:' })).to.have.text('10'); | |||
oliviertassinari
added
PR: ready to ship
and removed
PR: needs test
eps1lon
previously requested changes
May 27, 2020
|
| @@ -123,6 +124,7 @@ const TablePagination = React.forwardRef(function TablePagination(props, ref) { | |||
| input={<InputBase className={clsx(classes.input, classes.selectRoot)} />} | |||
| value={rowsPerPage} | |||
| onChange={onChangeRowsPerPage} | |||
| id={selectId} | |||
There was a problem hiding this comment.
If an id is required, should it be generated internally by the Select component? Meaning moving the useId from the TablePagination to here:
There was a problem hiding this comment.
Also removing the filter of #20356 as no longer useful?
There was a problem hiding this comment.
I'd like to handle this in a separate PR.
|
@eps1lon Thanks for polishing it, much better! @AlexAndriyanenko thanks for looking into it :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #20488