[core] Batch small changes #21249
Merged
[core] Batch small changes #21249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Apply mui#21120 to the other labels. - Remove the Material Design label. I believe users shouldn't be able to set any specific label on the issues. It should up to the core team to evaluate what's a bug, a new feature, a question, a support, etc.
This is an effort to reduce the concerns raised in mui#21209. We don't need to duplicate the information for the 1px web <-> 1px screen variant of the images.
Google Analytics doesn't provide any tool to group close values. We have to group the value ourselves to reduce the cardinality of the possible values this dimension can take. After 24 hours, we had 185 different values mui#21209 (comment). After 4 days, we had 357 different values. My hope is that we will have most of the values (> 1%) on less than 40 possible values). This will make studying the result easier.
A second iteration mui#20433 (comment).
@mikbry I would highly recommend to rename the package. I have struggeld to find it on Google, even knowing it existed. `material-ui-color-pickers` would be more efficient.
Spotted ahrefs
oliviertassinari
added
the
umbrella
|
@material-ui/core: parsed: +Infinity% , gzip: +Infinity% Details of bundle changes.Comparing: 1e1dd57...11acb65 Details of page changes
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't need to duplicate the information for the 1px web <-> 1px screen variant of the images.
We have to group the value ourselves to reduce the cardinality of the possible values this
dimension can take. After 24 hours, we had 185 different values [docs] Track pixel ratio #21209 (comment). After 4 days, we had 357 different values. My hope is that we will have most of the values (> 1%) on less than 40 possible values. This will make studying the result easier.
I have struggled to find it on Google, even knowing it existed.
material-ui-color-pickerswould be more efficient.