-
-
Notifications
You must be signed in to change notification settings - Fork 31.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TrapFocus] Prevent possible crash in React 17 #22263
Merged
eps1lon
merged 1 commit into
mui:master
from
eps1lon:feat/TrapFocus/deferred-effect-cleanup-guard-master
Aug 19, 2020
Merged
[TrapFocus] Prevent possible crash in React 17 #22263
eps1lon
merged 1 commit into
mui:master
from
eps1lon:feat/TrapFocus/deferred-effect-cleanup-guard-master
Aug 19, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eps1lon
added
bug 🐛
Something doesn't work
component: FocusTrap
The React component.
labels
Aug 18, 2020
eps1lon
added
new feature
New feature or request
and removed
bug 🐛
Something doesn't work
labels
Aug 18, 2020
Details of bundle changes.Comparing: 076a5fb...3fa6fe1 Details of page changes
|
oliviertassinari
approved these changes
Aug 18, 2020
eps1lon
deleted the
feat/TrapFocus/deferred-effect-cleanup-guard-master
branch
August 19, 2020 07:45
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #22262