Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Add Backstage to showcase #22428

Merged
merged 2 commits into from
Aug 31, 2020
Merged

[docs] Add Backstage to showcase #22428

merged 2 commits into from
Aug 31, 2020

Conversation

stefanalund
Copy link

@mui-pr-bot
Copy link

mui-pr-bot commented Aug 31, 2020

Details of bundle changes

Generated by 🚫 dangerJS against 6fea285

@oliviertassinari oliviertassinari added the docs Improvements or additions to the documentation label Aug 31, 2020
Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening the pull request. I have cropped the image to fit.

Capture d’écran 2020-08-31 à 14 56 48

@stefanalund
Copy link
Author

Thanks @oliviertassinari 🙏

@oliviertassinari oliviertassinari merged commit 2c10ae5 into mui:next Aug 31, 2020
@oliviertassinari
Copy link
Member

@stefanalund Thanks for putting trust in our library.

@stefanalund
Copy link
Author

Pretty sure we are the ones who should be thankful ❤️ We have been happy users for a couple of years now for our internal version of Backstage, and more recently with the open source release. Keep up the amazing work!

@stefanalund stefanalund deleted the patch-1 branch August 31, 2020 14:45
@oliviertassinari
Copy link
Member

By any change, is your organization using ag-grid? We are working on an open source and commercial alternative, we are looking for early users.

@stefanalund
Copy link
Author

No, sorry.

@stefanalund
Copy link
Author

@oliviertassinari Backstage still doesn't show in the list. Did something go wrong or is this expected?

@oliviertassinari
Copy link
Member

oliviertassinari pushed a commit that referenced this pull request Sep 1, 2020
@oliviertassinari
Copy link
Member

I have cherry-picked it to master, it should be live on the main domain in a couple of minutes.

@stefanalund
Copy link
Author

Lovely -- thanks a lot 😍

@mbrookes
Copy link
Member

mbrookes commented Sep 1, 2020

@stefanalund If you could submit an image 900 X 675 that isn't cropped, that would be even better. 👍

@oliviertassinari
Copy link
Member

oliviertassinari commented Sep 1, 2020

I think that the dimensions should be 900 X 675 => 1200 X 900. It would match the max size we use to display the showcase when the image is rendered: 600 X 450, with a x2 grow factor to account for retina screens. I don't remember why we started with a different format for the other websites.

@stefanalund
Copy link
Author

Fixed in #22458

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants