Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[material-ui][Dialog] The dialog scrollbar is not displayed in Safari when opening dialog for the second time #40233

Closed
2 tasks done
vkoman opened this issue Dec 18, 2023 · 4 comments
Closed
2 tasks done

[material-ui][Dialog] The dialog scrollbar is not displayed in Safari when opening dialog for the second time #40233

vkoman opened this issue Dec 18, 2023 · 4 comments
Assignees
@samuelsycamore
Labels
browser: Safari component: dialog This is the name of the generic UI component, not the React module! package: material-ui Specific to @mui/material status: expected behavior Does not imply the behavior is intended. Just that we know about it and can't work around it

Comments

@vkoman
Copy link

vkoman commented Dec 18, 2023

Duplicates

  • I have searched the existing issues

Latest version

  • I have tested the latest version

Steps to reproduce 馃暪

Link to live example: https://codesandbox.io/s/misty-morning-zqn68y?file=/Demo.tsx

Steps:

open Safari on mac
dialog has keepMounted={true}, so it will not rerender on the next open

  1. click open Dialog - scroll down - the scroll bar is visible
  2. click Close Dialog
  3. click open Dialog again - scroll down - the scroll bar is NOT visible

Current behavior 馃槸

The scroll bar disappears after opening the dialog for the second time on Safari
Works properly on Chome

Expected behavior 馃

the scroll bar should be always visible

Context 馃敠

No response

Your environment 馃寧

No response
@vkoman vkoman added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Dec 18, 2023
@samuelsycamore samuelsycamore changed the title [Dialog with keepMounted on Safari] The dialog scrollbar is not displayed in Safari when opening dialog for the second time [material-ui][Dialog] The dialog scrollbar is not displayed in Safari when opening dialog for the second time Dec 18, 2023
@samuelsycamore samuelsycamore added component: dialog This is the name of the generic UI component, not the React module! package: material-ui Specific to @mui/material labels Dec 18, 2023
@samuelsycamore
Copy link
Member

samuelsycamore commented Dec 18, 2023 •
edited

Hi @vkoman, can you share a screen recording of the problem you're encountering? I tested the demo in Chrome and Safari and both had the same (expected) behavior for me (unless I'm misunderstanding the issue).

@samuelsycamore samuelsycamore added status: waiting for author Issue with insufficient information and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Dec 18, 2023
@vkoman
Copy link
Author

vkoman commented Dec 19, 2023

here is a recording of code sandbox example
I am using Safari Version 17.2 (18617.1.17.11.11, 18617)
https://github.com/mui/material-ui/assets/8247394/a41ddc8a-af5f-4e7d-a747-6051389d9a51

@github-actions github-actions bot added status: waiting for maintainer These issues haven't been looked at yet by a maintainer and removed status: waiting for author Issue with insufficient information labels Dec 19, 2023
@vkoman
Copy link
Author

vkoman commented Dec 19, 2023

it works properly on Chrome

Screen.Recording.2023-12-19.at.09.01.31.mov

@samuelsycamore
Copy link
Member

From what I'm seeing, this is expected behavior鈥攊t's just the way Safari behaves. Mac OS users can change this default behavior in system settings.

@samuelsycamore samuelsycamore closed this as not planned Won't fix, can't repro, duplicate, stale Mar 4, 2024
@samuelsycamore samuelsycamore added status: expected behavior Does not imply the behavior is intended. Just that we know about it and can't work around it browser: Safari and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@samuelsycamore samuelsycamore

Labels
browser: Safari component: dialog This is the name of the generic UI component, not the React module! package: material-ui Specific to @mui/material status: expected behavior Does not imply the behavior is intended. Just that we know about it and can't work around it
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vkoman @samuelsycamore