Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[material-ui][Rating] arrowUp and arrowDown are reversed #41290

Open
michelengelen opened this issue Feb 27, 2024 · 5 comments
Open

[material-ui][Rating] arrowUp and arrowDown are reversed #41290

michelengelen opened this issue Feb 27, 2024 · 5 comments
Assignees
@mj12albert
Labels
accessibility a11y component: rating This is the name of the generic UI component, not the React module! package: material-ui Specific to @mui/material status: expected behavior Does not imply the behavior is intended. Just that we know about it and can't work around it

Comments

@michelengelen
Copy link
Member

michelengelen commented Feb 27, 2024 •
edited by github-actions bot

Steps to reproduce

Link to live example: Basic Rating

Steps:

  1. tab into the rating
  2. press arrow up/down
  3. value setting is reversed

Current behavior

arrowUp decreases value
arrowDown increases value

Expected behavior

arrowUp increases value
arrowDown decreases value

Context

No response

Your environment

No response

Search keywords: rating arrow up down value
@michelengelen michelengelen added status: waiting for maintainer These issues haven't been looked at yet by a maintainer component: rating This is the name of the generic UI component, not the React module! bug 🐛 Something doesn't work accessibility a11y labels Feb 27, 2024
@michelengelen michelengelen mentioned this issue Feb 27, 2024
Closed
@danilo-leal danilo-leal changed the title [Rating] arrowUp and arrowDown are reversed [material-ui][Rating] arrowUp and arrowDown are reversed Feb 27, 2024
@danilo-leal danilo-leal added the package: material-ui Specific to @mui/material label Feb 27, 2024
@KirankumarAmbati
Copy link
Contributor

Is it by design that Rating component behaves this way? Below ones are also working same as material UI:
Uber: https://baseweb.design/components/rating/
Ebay: https://opensource.ebay.com/mindpatterns/input/star-rating/

Arrow Left & Right is functioning correctly for all 3 components, including material UI.

@michelengelen
Copy link
Member Author

OK, maybe it is intended behavior ... it just feels so wrong to hit the arrow down key and the value going up!

@KirankumarAmbati
Copy link
Contributor

OK, maybe it is intended behavior ... it just feels so wrong to hit the arrow down key and the value going up!

Agreed.

@samuelsycamore
Copy link
Member

As far as I know this is intended behavior. From an a11y perspective I think it would be even more strange if they were reversed from the existing implementation.

@samuelsycamore samuelsycamore added status: expected behavior Does not imply the behavior is intended. Just that we know about it and can't work around it and removed bug 🐛 Something doesn't work status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Mar 4, 2024
@michelengelen
Copy link
Member Author

As far as I know this is intended behavior. From an a11y perspective I think it would be even more strange if they were reversed from the existing implementation.

Yeah ... considering this I think we can close this one! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mj12albert mj12albert

Labels
accessibility a11y component: rating This is the name of the generic UI component, not the React module! package: material-ui Specific to @mui/material status: expected behavior Does not imply the behavior is intended. Just that we know about it and can't work around it
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@mj12albert @KirankumarAmbati @michelengelen @danilo-leal @samuelsycamore