Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[icons] Mismatch design for ThumbUpOffAltSharp compared to ThumbDownOffAltSharpIcon #41325

Open
anderslind opened this issue Mar 1, 2024 · 3 comments
Labels
bug 🐛 Something doesn't work package: icons Specific to @mui/icons

Comments

@anderslind
Copy link

anderslind commented Mar 1, 2024

Steps to reproduce

Link to live example: (required)

Steps:

  1. Go to https://mui.com/material-ui/material-icons/?query=thumb&theme=Sharp
  2. Check ThumbDownOffAltSharpIcon compared to ThumbUpOffAltSharpIcon. The latter seems off compared to the former.

Current behavior

No response

Expected behavior

No response

Context

No response

Your environment

npx @mui/envinfo
  System:
    OS: macOS 14.0
    Browser: Chrome Version 121.0.6167.184 (Official Build) (arm64)
  Binaries:
    Node: 16.20.2 - ~/.nvm/versions/node/v16.20.2/bin/node
    npm: 8.19.4 - ~/.nvm/versions/node/v16.20.2/bin/npm
    pnpm: Not Found
  Browsers:
    Chrome: 121.0.6167.184
    Edge: Not Found
    Safari: 17.0
  npmPackages:
    @emotion/react: 11.10.6 => 11.10.6
    @emotion/styled: ^11.10.6 => 11.11.0
    @mui/base:  5.0.0-beta.37
    @mui/core-downloads-tracker:  5.15.11
    @mui/icons-material: ^5.15.11 => 5.15.11
    @mui/material: ^5.15.11 => 5.15.11
    @mui/private-theming:  5.15.11
    @mui/styled-engine:  5.15.11
    @mui/styles: ^5.15.11 => 5.15.11
    @mui/system:  5.15.11
    @mui/types:  7.2.13
    @mui/utils:  5.15.11
    @types/react: 18.0.28 => 18.0.28
    react: 18.2.0 => 18.2.0
    react-dom: 18.2.0 => 18.2.0
    typescript: ^5.0.4 => 5.0.4

Search keywords: icon thumb ThumbUpOffAltSharp

@anderslind anderslind added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Mar 1, 2024
@zannager zannager added the package: icons Specific to @mui/icons label Mar 1, 2024
@yasminebeji
Copy link

Hi @anderslind can you please elaborate more on the issue as i am not abmeto find the off part comparing the ThumbUpOffAltSharpIcon and the ThumbDownOffAltSharpIcon in the link you sent

@fahdmk
Copy link

fahdmk commented Mar 3, 2024

from what i see the thumb down is correct it is the thumb up off is similar to the regular thumb up
image
image

@anderslind
Copy link
Author

Yes, I would expect the ThumbUp to have a transparent inner area like that of ThumbDown.

Screenshot 2024-03-04 at 07 52 35
Screenshot 2024-03-04 at 07 52 44

@danilo-leal danilo-leal changed the title Icon mismatch design for ThumbUpOffAltSharp compared to ThumbDownOffAltSharpIcon. [icons] Mismatch design for ThumbUpOffAltSharp compared to ThumbDownOffAltSharpIcon Mar 5, 2024
@ZeeshanTamboli ZeeshanTamboli added bug 🐛 Something doesn't work and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Mar 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work package: icons Specific to @mui/icons
Projects
None yet
Development

No branches or pull requests

6 participants