Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pigment-css][core] Use npm package name for folder name #41332

Closed
oliviertassinari opened this issue Mar 2, 2024 · 2 comments · Fixed by #41453
Closed

[pigment-css][core] Use npm package name for folder name #41332

oliviertassinari opened this issue Mar 2, 2024 · 2 comments · Fixed by #41453
Labels
core Infrastructure work going on behind the scenes package: pigment-css Specific to @pigment-css/*

Comments

@oliviertassinari
Copy link
Member

oliviertassinari commented Mar 2, 2024

Steps to reproduce

#41317 (comment)

Current behavior

No response

Expected behavior

No response

Context

So developers who browse the source have 0 doubts that they are at the right place.

Your environment

npx @mui/envinfo
  Don't forget to mention which browser you used.
  Output from `npx @mui/envinfo` goes here.

Search keywords: folder name

@oliviertassinari oliviertassinari added package: system Specific to @mui/system core Infrastructure work going on behind the scenes status: waiting for maintainer These issues haven't been looked at yet by a maintainer and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Mar 2, 2024
@danilo-leal
Copy link
Contributor

I believe this PR #41354 should be enough to close this issue 👍

@oliviertassinari
Copy link
Member Author

oliviertassinari commented Mar 10, 2024

It's a great first step. The examples look correct: https://github.com/mui/material-ui/tree/master/examples/pigment-css-nextjs-ts.

But the package folder names don't match with the npm package name, e.g. https://github.com/mui/material-ui/tree/master/packages/pigment-react. I'm reopening.

@oliviertassinari oliviertassinari added the package: pigment-css Specific to @pigment-css/* label Mar 10, 2024
@oliviertassinari oliviertassinari changed the title [system][core] Use npm package name for folder name [pigment-css][core] Use npm package name for folder name Mar 10, 2024
@danilo-leal danilo-leal removed the package: system Specific to @mui/system label Mar 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Infrastructure work going on behind the scenes package: pigment-css Specific to @pigment-css/*
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants